Source/bindings/core/v8/WorkerScriptController.cpp - Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/V8Initializer.cpp ('k') | Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp » ('j') | Source/core/dom/ExecutionContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp

index d7e3a93b43fd4276e6d5dec0044caf869bb75833..f1ce776670265385efa9d28be693889f48109053 100644

--- a/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -46,6 +46,7 @@

#include "bindings/modules/v8/V8ServiceWorkerGlobalScope.h"

#include "core/events/ErrorEvent.h"

#include "core/frame/DOMTimer.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/ScriptCallStack.h"

#include "core/workers/SharedWorkerGlobalScope.h"

#include "core/workers/WorkerGlobalScope.h"

@@ -217,7 +218,7 @@ void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode, RefPtr

} else {

event = ErrorEvent::create(state.errorMessage, state.sourceURL, state.lineNumber, state.columnNumber, m_world.get());

}

- m_workerGlobalScope.reportException(event, nullptr, NotSharableCrossOrigin);

+ m_workerGlobalScope.reportException(event, ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, event->messageForConsole(), event->filename(), event->lineno(), event->colno()));

}