Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: Source/bindings/core/v8/ScriptPreprocessor.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptPreprocessor.cpp
diff --git a/Source/bindings/core/v8/ScriptPreprocessor.cpp b/Source/bindings/core/v8/ScriptPreprocessor.cpp
index 5867a8ca8b9d97f66e0f9c6389411144551e32e5..d3553d1b785001356f28fdc08192142b198cf97d 100644
--- a/Source/bindings/core/v8/ScriptPreprocessor.cpp
+++ b/Source/bindings/core/v8/ScriptPreprocessor.cpp
@@ -39,6 +39,7 @@
#include "core/frame/FrameConsole.h"
#include "core/frame/FrameHost.h"
#include "core/frame/LocalFrame.h"
+#include "core/inspector/ConsoleMessage.h"
#include "wtf/TemporaryChange.h"
namespace WebCore {
@@ -59,13 +60,13 @@ ScriptPreprocessor::ScriptPreprocessor(const ScriptSourceCode& preprocessorSourc
frame->script().executeScriptInIsolatedWorld(ScriptPreprocessorIsolatedWorldId, sources, DOMWrapperWorld::mainWorldExtensionGroup, &scriptResults);
if (scriptResults.size() != 1) {
- frame->console().addMessage(JSMessageSource, ErrorMessageLevel, "ScriptPreprocessor internal error, one ScriptSourceCode must give exactly one result.");
+ frame->console().addMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, "ScriptPreprocessor internal error, one ScriptSourceCode must give exactly one result."));
return;
}
v8::Local<v8::Value> preprocessorFunction = scriptResults[0];
if (preprocessorFunction.IsEmpty() || !preprocessorFunction->IsFunction()) {
- frame->console().addMessage(JSMessageSource, ErrorMessageLevel, "The preprocessor must compile to a function.");
+ frame->console().addMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, "The preprocessor must compile to a function."));
return;
}
m_preprocessorFunction.set(m_scriptState->isolate(), v8::Handle<v8::Function>::Cast(preprocessorFunction));

Powered by Google App Engine
This is Rietveld 408576698