Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 469
470 [Debugger, Inline=FastReturn] 470 [Debugger, Inline=FastReturn]
471 InspectorInstrumentationCookie traceAsyncCallbackStarting([Keep] ExecutionCo ntext*, int operationId); 471 InspectorInstrumentationCookie traceAsyncCallbackStarting([Keep] ExecutionCo ntext*, int operationId);
472 472
473 [Debugger, Inline=FastReturn] 473 [Debugger, Inline=FastReturn]
474 void traceAsyncCallbackCompleted(const InspectorInstrumentationCookie&); 474 void traceAsyncCallbackCompleted(const InspectorInstrumentationCookie&);
475 } 475 }
476 476
477 interface InspectorConsoleInstrumentation { 477 interface InspectorConsoleInstrumentation {
478 478
479 #include "core/inspector/ConsoleMessage.h"
479 #include "core/inspector/ScriptArguments.h" 480 #include "core/inspector/ScriptArguments.h"
480 #include "core/inspector/ScriptCallStack.h" 481 #include "core/inspector/ScriptCallStack.h"
481 482
482 // FIXME: Convert to ScriptArguments to match non-worker context.
483 // Use the same implementation as above as a similar method dispatched on Pa ge. 483 // Use the same implementation as above as a similar method dispatched on Pa ge.
484 [Console] 484 [Console]
485 void addMessageToConsole(ExecutionContext* context, MessageSource source, Me ssageType type, MessageLevel level, const String& message, PassRefPtrWillBeRawPt r<ScriptCallStack> callStack, unsigned long requestIdentifier = 0); 485 void addMessageToConsole(ExecutionContext* context, PassRefPtr<ConsoleMessag e> consoleMessage);
aandrey 2014/08/05 07:35:44 PassRefPtr<ConsoleMessage> -> ConsoleMessage* othe
kozyatinskiy1 2014/08/08 13:10:26 Done.
486
487 // Use the same implementation as above as a similar method dispatched on Pa ge.
488 [Console]
489 void addMessageToConsole(ExecutionContext* context, MessageSource source, Me ssageType type, MessageLevel level, const String& message, const String& scriptI d, unsigned lineNumber, unsigned columnNumber, ScriptState* state, unsigned long requestIdentifier = 0);
490 486
491 [Console, Debugger] 487 [Console, Debugger]
492 void addConsoleAPIMessageToConsole(ExecutionContext* context, MessageType ty pe, MessageLevel level, const String& message, ScriptState* state, PassRefPtrWil lBeRawPtr<ScriptArguments> arguments, unsigned long requestIdentifier = 0); 488 void addConsoleAPIMessageToConsole(ExecutionContext* context, MessageType ty pe, MessageLevel level, const String& message, ScriptState* state, PassRefPtrWil lBeRawPtr<ScriptArguments> arguments, unsigned long requestIdentifier = 0);
493 489
494 [Console] 490 [Console]
495 void consoleCount(ExecutionContext* context, ScriptState* state, PassRefPtrW illBeRawPtr<ScriptArguments> arguments); 491 void consoleCount(ExecutionContext* context, ScriptState* state, PassRefPtrW illBeRawPtr<ScriptArguments> arguments);
496 492
497 [Timeline, Console] 493 [Timeline, Console]
498 void consoleTime([Keep] ExecutionContext* context, const String& title); 494 void consoleTime([Keep] ExecutionContext* context, const String& title);
499 495
(...skipping 28 matching lines...) Expand all
528 interface InspectorCanvasInstrumentation { 524 interface InspectorCanvasInstrumentation {
529 525
530 #include "bindings/core/v8/ScriptValue.h" 526 #include "bindings/core/v8/ScriptValue.h"
531 527
532 [Canvas] 528 [Canvas]
533 ScriptValue wrapCanvas2DRenderingContextForInstrumentation(Document*, const ScriptValue&); 529 ScriptValue wrapCanvas2DRenderingContextForInstrumentation(Document*, const ScriptValue&);
534 530
535 [Canvas] 531 [Canvas]
536 ScriptValue wrapWebGLRenderingContextForInstrumentation(Document*, const Scr iptValue&); 532 ScriptValue wrapWebGLRenderingContextForInstrumentation(Document*, const Scr iptValue&);
537 } 533 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698