Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2
Patch Set: address comments from Fady Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index fbf3ce43f5328d4d8c79f65694d86ba37a1322a1..7e48cfac391e7db3c229fc62669c75994f7b42a9 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1526,7 +1526,7 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
if (base::UTF16ToUTF8(params.mimeType) == kBrowserPluginMimeType) {
return render_view_->GetBrowserPluginManager()->CreateBrowserPlugin(
- render_view_.get(), frame, false);
+ render_view_.get(), frame, NULL);
}
#if defined(ENABLE_PLUGINS)
@@ -1540,8 +1540,12 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
return NULL;
if (info.type == content::WebPluginInfo::PLUGIN_TYPE_BROWSER_PLUGIN) {
+ BrowserPluginDelegate* browser_plugin_delegate =
+ GetContentClient()->renderer()->CreateBrowserPluginDelegate(
+ render_view_->GetMainRenderFrame(),
Fady Samuel 2014/09/02 20:30:01 Should this be taking in this instead?
lazyboy 2014/09/02 21:44:23 Yes. Ty. Done.
+ base::UTF16ToUTF8(params.mimeType));
return render_view_->GetBrowserPluginManager()->CreateBrowserPlugin(
- render_view_.get(), frame, true);
+ render_view_.get(), frame, browser_plugin_delegate);
}

Powered by Google App Engine
This is Rietveld 408576698