content/renderer/browser_plugin/browser_plugin_manager_impl.cc - Issue 376033002: Adding MimeHandlerView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager_impl.cc

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2

Patch Set: With the new attach approach Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/browser_plugin/browser_plugin_manager_impl.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_manager_impl.cc b/content/renderer/browser_plugin/browser_plugin_manager_impl.cc

index 8ada74e62c16343ae96c63f586b95aa1ac568766..a4e1539f6113b355375836d9e63c0da8325d8ead 100644

--- a/content/renderer/browser_plugin/browser_plugin_manager_impl.cc

+++ b/content/renderer/browser_plugin/browser_plugin_manager_impl.cc

@@ -23,8 +23,9 @@ BrowserPluginManagerImpl::~BrowserPluginManagerImpl() {

BrowserPlugin* BrowserPluginManagerImpl::CreateBrowserPlugin(

RenderViewImpl* render_view,

blink::WebFrame* frame,

- bool auto_navigate) {

- return new BrowserPlugin(render_view, frame, auto_navigate);

+ bool auto_navigate,

Fady Samuel 2014/08/29 18:52:32 Get rid of auto_navigate and mime_type and pass in

lazyboy 2014/08/29 22:08:25 Done.

+ const std::string& mime_type) {

+ return new BrowserPlugin(render_view, frame, auto_navigate, mime_type);

}

bool BrowserPluginManagerImpl::Send(IPC::Message* msg) {