Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: content/public/renderer/browser_plugin_delegate.h

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2
Patch Set: address comments from Fady Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_PUBLIC_RENDERER_BROWSER_PLUGIN_DELEGATE_H_
6 #define CONTENT_PUBLIC_RENDERER_BROWSER_PLUGIN_DELEGATE_H_
7
8 #include <string>
9
10 #include "content/common/content_export.h"
11
12 namespace content {
13
14 class RenderFrame;
15
16 // Maybe BrowserPluginLoadObserver?
Fady Samuel 2014/09/02 20:30:01 Let's add some more meaningful comment here? I wou
lazyboy 2014/09/02 21:44:22 Done.
17 class CONTENT_EXPORT BrowserPluginDelegate {
18 public:
19 BrowserPluginDelegate(RenderFrame* render_frame,
20 const std::string& mime_type) {}
21 virtual ~BrowserPluginDelegate() {}
22
23 virtual void SetElementInstanceID(int element_instance_id) {}
Fady Samuel 2014/09/02 20:30:01 Comment for each public method.
lazyboy 2014/09/02 21:44:23 Done.
24 virtual void DidFinishLoading() {}
25 virtual void DidReceiveData(const char* data, int data_length) {}
26 };
27
28 } // namespace content
29
30 #endif // CONTENT_PUBLIC_RENDERER_BROWSER_PLUGIN_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698