extensions/browser/guest_view/guest_view_constants.h - Issue 376033002: Adding MimeHandlerView.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/guest_view/guest_view_constants.h

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2

Patch Set: With the new attach approach Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« extensions/browser/extension_message_filter.cc ('K') | « extensions/browser/guest_view/guest_view_base.cc ('k') | extensions/browser/guest_view/guest_view_constants.cc » ('j') | extensions/browser/guest_view/guest_view_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Constants used for the WebView API.	5 // Constants used for the WebView API.

6	6

7 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_CONSTANTS_H_	7 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_CONSTANTS_H_

8 #define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_CONSTANTS_H_	8 #define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_CONSTANTS_H_

9	9

10 namespace guestview {	10 namespace guestview {

11	11

12 // Parameters/properties on events.	12 // Parameters/properties on events.

13 extern const char kIsTopLevel[];	13 extern const char kIsTopLevel[];

14 extern const char kReason[];	14 extern const char kReason[];

15 extern const char kUrl[];	15 extern const char kUrl[];

16 extern const char kUserGesture[];	16 extern const char kUserGesture[];

17	17

18 // Initialization parameters.	18 // Initialization parameters.

19 extern const char kParameterApi[];	19 extern const char kParameterApi[];

20 extern const char kParameterInstanceId[];	20 extern const char kParameterInstanceId[];

21	21

22 // Other.	22 // Other.

23 extern const char kGuestViewManagerKeyName[];	23 extern const char kGuestViewManagerKeyName[];

	24 extern const char kMimeTypeParam[];
	Fady Samuel 2014/08/29 18:52:32 I'd prefer not having a GuestView specific constan I'd prefer not having a GuestView specific constant here. lazyboy 2014/08/29 22:08:25 Makes sense. Removed the const. I'm using string l Show quoted text On 2014/08/29 18:52:32, Fady Samuel wrote: > I'd prefer not having a GuestView specific constant here. Makes sense. Removed the const. I'm using string literals for now instead until things settle down with the CL, added TODO in those places.
24 extern const int kInstanceIDNone;	25 extern const int kInstanceIDNone;

25	26

26 } // namespace guestview	27 } // namespace guestview

27	28

28 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_CONSTANTS_H_	29 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_CONSTANTS_H_

29	30

OLD	NEW