Extensions: DCHECK that all app pages are blessed before use.

extensions/renderer/dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/dispatcher.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
@@ skipping 239 matching lines @@
     // "invalid". This isn't interesting.
     if (extension_id != "invalid") {
       LOG(ERROR) << "Extension \"" << extension_id << "\" not found";
       RenderThread::Get()->RecordAction(
           UserMetricsAction("ExtensionNotFound_ED"));
     }
 
     extension_id = "";
   }
 
+  bool extension_is_platform_app = extension && extension->is_platform_app();
+
   Feature::Context context_type =
       ClassifyJavaScriptContext(extension,
                                 extension_group,
                                 ScriptContext::GetDataSourceURLForFrame(frame),
                                 frame->document().securityOrigin());
 
+  // Sanity check that all platform app URLs are given a blessed extension
+  // context. If not, the app page would be missing features such as APIs.
+  if (extension_is_platform_app)
+    DCHECK_EQ(Feature::BLESSED_EXTENSION_CONTEXT, context_type);

[lazyboy, 2014/07/21 20:24:50]

@kalman, so you're suggesting to add
if (!extension->permissions_data()->HasAPIPermission(..kWebView)) to this
DCHECK?

[not at google - send to devlin, 2014/07/21 20:34:09]

That would work, or a check like isWebviewProcess() if such a thing exists. plus
a check to make sure that it is indeed a content script context being created?

[lazyboy, 2014/07/21 22:03:20]

The process itself doesn't know much about he webview, but the script executor
has info about this,
ProgrammaticScriptInjector.params_.is_web_view, is that possible to reach to
that from here?
plus
I have e.g. in WebViewTest.Shim_TestChromeExtensionURL, a <webview> that
contains a <script> tag, that's causing context_type to be UNBLESSED_*
guest_with_inline_script.html:
...
<script>window.console.log('...');</script>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...
So this is not a content script, right?

I wonder why we this script is run on the platform app, or is this expected?

+
   ScriptContext* context =
       delegate_->CreateScriptContext(v8_context, frame, extension, context_type)
           .release();
   script_context_set_.Add(context);
 
   // Initialize origin permissions for content scripts, which can't be
   // initialized in |OnActivateExtension|.
   if (context_type == Feature::CONTENT_SCRIPT_CONTEXT)
     InitOriginPermissions(extension);
 
@@ skipping 13 matching lines @@
   // lazily evalulate to Event from event_bindings.js. For extensions only
   // though, not all webpages!
   if (context->extension()) {
     v8::Handle<v8::Object> chrome = AsObjectOrEmpty(GetOrCreateChrome(context));
     if (!chrome.IsEmpty())
       module_system->SetLazyField(chrome, "Event", kEventBindings, "Event");
   }
 
   UpdateBindingsForContext(context);
 
-  bool is_within_platform_app = IsWithinPlatformApp();
   // Inject custom JS into the platform app context.
-  if (is_within_platform_app) {
+  if (extension_is_platform_app) {
     module_system->Require("platformApp");
   }
 
   delegate_->RequireAdditionalModules(
-      module_system, extension, context_type, is_within_platform_app);
+      module_system, extension, context_type, extension_is_platform_app);
 
   VLOG(1) << "Num tracked contexts: " << script_context_set_.size();
 }
 
 void Dispatcher::WillReleaseScriptContext(
     WebFrame* frame,
     const v8::Handle<v8::Context>& v8_context,
     int world_id) {
   ScriptContext* context = script_context_set_.GetByV8Context(v8_context);
   if (!context)
@@ skipping 908 matching lines @@
     return v8::Handle<v8::Object>();
 
   if (bind_name)
     *bind_name = split.back();
 
   return bind_object.IsEmpty() ? AsObjectOrEmpty(GetOrCreateChrome(context))
                                : bind_object;
 }
 
 }  // namespace extensions