Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: Source/core/html/HTMLProgressElement.h

Issue 36973002: Clean up toHTMLFooElement() using DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLProgressElement.h
diff --git a/Source/core/html/HTMLProgressElement.h b/Source/core/html/HTMLProgressElement.h
index e9f624e4342f8b638b661ca50a7472c23898058e..ae50218e2faac1715946a27eb2b679abc3107241 100644
--- a/Source/core/html/HTMLProgressElement.h
+++ b/Source/core/html/HTMLProgressElement.h
@@ -74,12 +74,13 @@ inline bool isHTMLProgressElement(Node* node)
return node->hasTagName(HTMLNames::progressTag);
}
-inline HTMLProgressElement* toHTMLProgressElement(Node* node)
+inline bool isHTMLProgressElement(Node& node)
tkent 2013/10/24 02:02:19 This looks unnecessary.
gyuyoung-inactive 2013/10/24 02:08:19 Oops, I thought that this one was original functio
{
- ASSERT_WITH_SECURITY_IMPLICATION(!node || isHTMLProgressElement(node));
- return static_cast<HTMLProgressElement*>(node);
+ return node.hasTagName(HTMLNames::progressTag);
}
+DEFINE_NODE_TYPE_CASTS(HTMLProgressElement, hasTagName(HTMLNames::progressTag));
+
} // namespace
#endif

Powered by Google App Engine
This is Rietveld 408576698