Source/core/inspector/InjectedScript.h - Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InjectedScript.h

Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-evaluate-exception-details

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/console/console-eval-undefined-override-expected.txt ('k') | Source/core/inspector/InjectedScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InjectedScript.h

diff --git a/Source/core/inspector/InjectedScript.h b/Source/core/inspector/InjectedScript.h

index 607dd3088f61c979dc79de3d78d7cd5fb11c164e..cbe96a594f797df1c0c756a9441a35d21e4ed9c1 100644

--- a/Source/core/inspector/InjectedScript.h

+++ b/Source/core/inspector/InjectedScript.h

@@ -58,7 +58,8 @@ public:

bool returnByValue,

bool generatePreview,

RefPtr<TypeBuilder::Runtime::RemoteObject>* result,

- TypeBuilder::OptOutput<bool>* wasThrown);

+ TypeBuilder::OptOutput<bool>* wasThrown,

+ RefPtr<TypeBuilder::Debugger::ExceptionDetails>*);

void callFunctionOn(

ErrorString*,

const String& objectId,

@@ -79,7 +80,8 @@ public:

bool returnByValue,

bool generatePreview,

RefPtr<TypeBuilder::Runtime::RemoteObject>* result,

- TypeBuilder::OptOutput<bool>* wasThrown);

+ TypeBuilder::OptOutput<bool>* wasThrown,

+ RefPtr<TypeBuilder::Debugger::ExceptionDetails>*);

void restartFrame(ErrorString*, const ScriptValue& callFrames, const String& callFrameId, RefPtr<JSONObject>* result);

void getStepInPositions(ErrorString*, const ScriptValue& callFrames, const String& callFrameId, RefPtr<TypeBuilder::Array<TypeBuilder::Debugger::Location> >& positions);

void setVariableValue(ErrorString*, const ScriptValue& callFrames, const String* callFrameIdOpt, const String* functionObjectIdOpt, int scopeNumber, const String& variableName, const String& newValueStr);