Source/core/inspector/InspectorDebuggerAgent.h - Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.h

Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-evaluate-exception-details

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/console/console-eval-throw.html ('K') | « Source/core/inspector/InjectedScriptSource.js ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.h

diff --git a/Source/core/inspector/InspectorDebuggerAgent.h b/Source/core/inspector/InspectorDebuggerAgent.h

index 17393980b0d708e19566ff41eaca7ca6374bf195..711bfdea6e7374d6fc134314bac9600133725f75 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.h

+++ b/Source/core/inspector/InspectorDebuggerAgent.h

@@ -133,7 +133,8 @@ public:

const bool* returnByValue,

const bool* generatePreview,

RefPtr<TypeBuilder::Runtime::RemoteObject>& result,

- TypeBuilder::OptOutput<bool>* wasThrown) OVERRIDE FINAL;

+ TypeBuilder::OptOutput<bool>* wasThrown,

+ RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) OVERRIDE FINAL;

virtual void compileScript(ErrorString*, const String& expression, const String& sourceURL, const int* executionContextId, TypeBuilder::OptOutput<TypeBuilder::Debugger::ScriptId>*, RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) OVERRIDE;

virtual void runScript(ErrorString*, const TypeBuilder::Debugger::ScriptId&, const int* executionContextId, const String* objectGroup, const bool* doNotPauseOnExceptionsAndMuteConsole, RefPtr<TypeBuilder::Runtime::RemoteObject>& result, RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) OVERRIDE;

virtual void setOverlayMessage(ErrorString*, const String*) OVERRIDE;