Source/core/inspector/InjectedScriptBase.h - Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InjectedScriptBase.h

Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-evaluate-exception-details

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/console/console-eval-throw-expected.txt ('K') | « Source/core/inspector/InjectedScript.cpp ('k') | Source/core/inspector/InjectedScriptBase.cpp » ('j') | Source/core/inspector/InjectedScriptSource.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InjectedScriptBase.h

diff --git a/Source/core/inspector/InjectedScriptBase.h b/Source/core/inspector/InjectedScriptBase.h

index 8cb386bfbeac129548852beebae2f5fd2b51a10c..7906ea03510e85c837b22b8e9c291d2dbf6074a6 100644

--- a/Source/core/inspector/InjectedScriptBase.h

+++ b/Source/core/inspector/InjectedScriptBase.h

@@ -66,7 +66,7 @@ protected:

const ScriptValue& injectedScriptObject() const;

ScriptValue callFunctionWithEvalEnabled(ScriptFunctionCall&, bool& hadException) const;

void makeCall(ScriptFunctionCall&, RefPtr<JSONValue>* result);

- void makeEvalCall(ErrorString*, ScriptFunctionCall&, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown);

+ void makeEvalCall(ErrorString*, ScriptFunctionCall&, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown, RefPtr<TypeBuilder::Debugger::ExceptionDetails>* = 0);

private:

String m_name;