Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 367653002: Add a FrameHostMsg_BeginNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a stub for CommitNavigation to clarify lifetime of rfh Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index ceb22e2ee244abeb9484f0b690b97f5870278c78..c954962f69bc1c4121c4780462452d5bfe2189c3 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -10,6 +10,8 @@
#include "content/browser/frame_host/navigator.h"
#include "content/common/content_export.h"
+struct FrameMsg_Navigate_Params;
+
namespace content {
class NavigationControllerImpl;
@@ -23,6 +25,13 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
NavigatorImpl(NavigationControllerImpl* navigation_controller,
NavigatorDelegate* delegate);
+ // Fills in |params| based on the content of |entry|.
+ static void MakeNavigateParams(const NavigationEntryImpl& entry,
+ const NavigationControllerImpl& controller,
+ NavigationController::ReloadType reload_type,
+ base::TimeTicks navigation_start,
+ FrameMsg_Navigate_Params* params);
+
// Navigator implementation.
virtual NavigationController* GetController() OVERRIDE;
virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
@@ -66,6 +75,12 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
bool should_replace_current_entry,
bool user_gesture) OVERRIDE;
+ // Will crash the browser if |render_frame_host| is a Web-UI renderer that
+ // tries to display a non Web UI |url|.
+ virtual void CheckWebUIRendererDoesNotDisplayNormalURL(
+ RenderFrameHostImpl* render_frame_host,
+ const GURL& url) OVERRIDE;
+
private:
virtual ~NavigatorImpl() {}
« no previous file with comments | « content/browser/frame_host/navigator.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698