Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: content/common/resource_request_body.h

Issue 367653002: Add a FrameHostMsg_BeginNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test + fixed bug in parent_is_render_frame_computation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/resource_request_body.h
diff --git a/content/common/resource_request_body.h b/content/common/resource_request_body.h
index c060c7234e8741041675524a4fc4baf8fdb5ca68..c1a4791ffc95e7bfc7bf5ae23b8d1427a96dd5a5 100644
--- a/content/common/resource_request_body.h
+++ b/content/common/resource_request_body.h
@@ -23,12 +23,13 @@ namespace content {
// A struct used to represent upload data. The data field is populated by
// WebURLLoader from the data given as WebHTTPBody.
class CONTENT_EXPORT ResourceRequestBody
- : public base::RefCounted<ResourceRequestBody>,
+ : public base::RefCountedThreadSafe<ResourceRequestBody>,
nasko 2014/07/07 11:35:09 Is there a different pattern we might use for send
clamy 2014/07/07 13:36:23 I'm afraid I don't see a better one :).
public base::SupportsUserData {
public:
typedef webkit_common::DataElement Element;
ResourceRequestBody();
+ virtual ~ResourceRequestBody();
nasko 2014/07/07 11:35:09 Why is the destructor now public?
clamy 2014/07/07 13:36:23 Since I forgot to change the friend class, it woul
void AppendBytes(const char* bytes, int bytes_len);
void AppendFileRange(const base::FilePath& file_path,
@@ -52,7 +53,6 @@ class CONTENT_EXPORT ResourceRequestBody
private:
friend class base::RefCounted<ResourceRequestBody>;
nasko 2014/07/07 11:35:09 Shouldn't this be RefCountedThreadSafe?
clamy 2014/07/07 13:36:23 Done.
- virtual ~ResourceRequestBody();
std::vector<Element> elements_;
int64 identifier_;

Powered by Google App Engine
This is Rietveld 408576698