Add a FrameHostMsg_BeginNavigation IPC

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
+#include "content/browser/frame_host/navigation_request.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/browser/frame_host/render_frame_host_manager.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/webui/web_ui_controller_factory_registry.h"
 #include "content/common/frame_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
@@ skipping 336 matching lines @@
     // BeforeUnload finishes.
     ntp_rvh->SendBeforeUnloadACK(true);
 
     dest_rvh->SendNavigate(101, kDestUrl);
     ntp_rvh->OnSwappedOut(false);
 
     EXPECT_TRUE(ntp_rvh->IsSwappedOut());
     return ntp_rvh;
   }
 
+  NavigationRequest* NavigationRequestForRenderFrameManager(
+      RenderFrameHostManager* manager) const {
+    return manager->navigation_request_for_testing();
+  }
+
  private:
   RenderFrameHostManagerTestWebUIControllerFactory factory_;
   scoped_ptr<FrameLifetimeConsistencyChecker> lifetime_checker_;
 };
 
 // Tests that when you navigate from a chrome:// url to another page, and
 // then do that same thing in another tab, that the two resulting pages have
 // different SiteInstances, BrowsingInstances, and RenderProcessHosts. This is
 // a regression test for bug 9364.
 TEST_F(RenderFrameHostManagerTest, NewTabPageProcesses) {
@@ skipping 1461 matching lines @@
     static_cast<SiteInstanceImpl*>(
         pending_rfh->GetSiteInstance())->increment_active_view_count();
 
     main_test_rfh()->OnMessageReceived(
         FrameHostMsg_BeforeUnload_ACK(0, false, now, now));
     EXPECT_FALSE(contents()->cross_navigation_pending());
     EXPECT_FALSE(rvh_deleted_observer.deleted());
   }
 }
 
+// Project PlzNavigate: Test that a proper NavigationRequest is created by
+// BeginNavigation.
+TEST_F(RenderFrameHostManagerTest,PlzNavigateBeginNavigation) {

[ppi, 2014/07/07 14:10:05]

nit: missing space after comma

[clamy, 2014/07/08 14:21:39]

Done.

+  const GURL kUrl1("http://www.google.com/");
+  const GURL kUrl2("http://www.chromium.org/");
+  const GURL kUrl3("http://www.gmail.com/");
+
+  // Navigate to the first page.
+  contents()->NavigateAndCommit(kUrl1);
+  TestRenderViewHost* rvh1 = test_rvh();
+  EXPECT_EQ(RenderViewHostImpl::STATE_DEFAULT, rvh1->rvh_state());
+
+  // Add a subframe.
+  TestRenderFrameHost* subframe_rfh = static_cast<TestRenderFrameHost*>(
+      contents()->GetFrameTree()->AddFrame(
+          contents()->GetFrameTree()->root(), 14, "Child"));
+
+  // Simulate a BeginNavigation IPC on the subframe.
+  subframe_rfh->SendBeginNavigationWithURL(kUrl2);
+  NavigationRequest* subframe_request =
+      NavigationRequestForRenderFrameManager(
+          subframe_rfh->frame_tree_node()->render_manager());
+  DCHECK(subframe_request);

[ppi, 2014/07/07 14:10:05]

We probably should be using ASSERT_* instead of (D)CHECK in tests.

[clamy, 2014/07/08 14:21:39]

Done.

+  EXPECT_EQ(kUrl2, subframe_request->info_for_testing().url);
+  // First party for cookies url should be that of the main frame.
+  EXPECT_EQ(
+      kUrl1, subframe_request->info_for_testing().first_party_for_cookies);
+  EXPECT_FALSE(subframe_request->info_for_testing().is_main_frame);
+  EXPECT_TRUE(subframe_request->info_for_testing().parent_is_main_frame);
+
+  // Simulate a BeginNavigation IPC on the main frame.
+  main_test_rfh()->SendBeginNavigationWithURL(kUrl3);
+  NavigationRequest* main_request =
+      NavigationRequestForRenderFrameManager(
+        main_test_rfh()->frame_tree_node()->render_manager());
+  DCHECK(main_request);

[ppi, 2014/07/07 14:10:05]

See above.

[clamy, 2014/07/08 14:21:39]

Done.

+  EXPECT_EQ(kUrl3, main_request->info_for_testing().url);
+  EXPECT_EQ(kUrl3, main_request->info_for_testing().first_party_for_cookies);
+  EXPECT_TRUE(main_request->info_for_testing().is_main_frame);
+  EXPECT_FALSE(main_request->info_for_testing().parent_is_main_frame);
+}
+
 }  // namespace content