NetworkPanel: do not hold request itself in stale requests map.

Source/devtools/front_end/network/NetworkPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 42 matching lines @@
     WebInspector.VBox.call(this);
     this.registerRequiredCSS("networkLogView.css");
     this.registerRequiredCSS("filter.css");
     this.registerRequiredCSS("suggestBox.css");
 
     this._filterBar = filterBar;
     this._coulmnsVisibilitySetting = coulmnsVisibilitySetting;
     this._allowRequestSelection = false;
     this._requests = [];
     this._requestsById = {};
-    this._staleRequests = {};
+    /** @type {!Object.<string, boolean>} */
+    this._staleRequestIds = {};

[vsevik, 2014/07/02 13:06:00]

StringSet

     this._requestGridNodes = {};
     this._lastRequestGridNodeId = 0;
     this._mainRequestLoadTime = -1;
     this._mainRequestDOMContentLoadedTime = -1;
     this._matchedRequests = [];
     this._highlightedSubstringChanges = [];
     this._filteredOutRequests = new Map();
 
     /** @type {!Array.<!WebInspector.NetworkLogView.Filter>} */
     this._filters = [];
@@ skipping 581 matching lines @@
     _refreshIfNeeded: function()
     {
         if (this._needsRefresh)
             this.refresh();
     },
 
     _invalidateAllItems: function()
     {
         for (var i = 0; i < this._requests.length; ++i) {
             var request = this._requests[i];
-            this._staleRequests[request.requestId] = request;
+            this._staleRequestIds[request.requestId] = true;
         }
     },
 
     get calculator()
     {
         return this._calculator;
     },
 
     set calculator(x)
     {
@@ skipping 84 matching lines @@
         }
 
         this._removeAllNodeHighlights();
         var wasScrolledToLastRow = this._dataGrid.isScrolledToLastRow();
         var boundariesChanged = false;
         if (this.calculator.updateBoundariesForEventTime) {
             boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainRequestLoadTime) || boundariesChanged;
             boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainRequestDOMContentLoadedTime) || boundariesChanged;
         }
 
-        for (var requestId in this._staleRequests) {
-            var request = this._staleRequests[requestId];
+        for (var requestId in this._staleRequestIds) {
+            var request = this._requestsById[requestId];
             var node = this._requestGridNode(request);
             if (!node) {
                 // Create the timeline tree element and graph.
                 node = this._createRequestGridNode(request);
                 this._dataGrid.rootNode().appendChild(node);
             }
             node.refresh();
             this._applyFilter(node);
 
             if (this.calculator.updateBoundaries(request))
                 boundariesChanged = true;
 
             if (!node.isFilteredOut())
                 this._updateHighlightIfMatched(request);
         }
 
         if (boundariesChanged) {
             // The boundaries changed, so all item graphs are stale.
             this._invalidateAllItems();
         }
 
-        for (var requestId in this._staleRequests)
-            this._requestGridNode(this._staleRequests[requestId]).refreshGraph(this.calculator);
+        for (var requestId in this._staleRequestIds)
+            this._requestGridNode(this._requestsById[requestId]).refreshGraph(this.calculator);
 
-        this._staleRequests = {};
+        this._staleRequestIds = {};
         this._sortItems();
         this._updateSummaryBar();
         this._dataGrid.updateWidths();
         // FIXME: evaluate performance impact of moving this before a call to sortItems()
         if (wasScrolledToLastRow)
             this._dataGrid.scrollToLastRow();
     },
 
     _onRecordButtonClicked: function()
     {
         if (!this._recordButton.toggled)
             this._reset();
         this._recordButton.toggled = !this._recordButton.toggled;
     },
 
     _reset: function()
     {
         this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.ViewCleared);
 
         this._clearSearchMatchedList();
         if (this._popoverHelper)
             this._popoverHelper.hidePopover();
 
         if (this._calculator)
             this._calculator.reset();
 
         this._requests = [];
         this._requestsById = {};
-        this._staleRequests = {};
+        this._staleRequestIds = {};
         this._requestGridNodes = {};
         this._resetSuggestionBuilder();
 
         if (this._dataGrid) {
             this._dataGrid.rootNode().removeChildren();
             this._updateDividersIfNeeded();
             this._updateSummaryBar();
         }
 
         this._mainRequestLoadTime = -1;
@@ skipping 63 matching lines @@
         for (var i = 0, l = responseHeaders.length; i < l; ++i)
             this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.HasResponseHeader, responseHeaders[i].name);
         var cookies = request.responseCookies;
         for (var i = 0, l = cookies ? cookies.length : 0; i < l; ++i) {
             var cookie = cookies[i];
             this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.SetCookieDomain, cookie.domain());
             this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.SetCookieName, cookie.name());
             this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.SetCookieValue, cookie.value());
         }
 
-        this._staleRequests[request.requestId] = request;
+        this._staleRequestIds[request.requestId] = true;
         this._scheduleRefresh();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _willReloadPage: function(event)
     {
         this._recordButton.toggled = true;
         if (!this._preserveLogCheckbox.checked())
@@ skipping 2146 matching lines @@
 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, revert, a, b)
 {
     var aValue = a._request[propertyName];
     var bValue = b._request[propertyName];
     if (aValue > bValue)
         return revert ? -1 : 1;
     if (bValue > aValue)
         return revert ? 1 : -1;
     return a._request.indentityCompare(b._request);
 }