chrome/browser/android/tab_android.h - Issue 364793005: Implementation of GetFavicon for current tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.h

Issue 364793005: Implementation of GetFavicon for current tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.h

diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h

index 0ee5392e2a471a6176e6afb9ea5dbf83652b5aff..ad45a8ea35fc27b4aa214ebeb4c051f1a9de861c 100644

--- a/chrome/browser/android/tab_android.h

+++ b/chrome/browser/android/tab_android.h

@@ -147,6 +147,10 @@ class TabAndroid : public CoreTabHelperDelegate,

jstring jurl,

jstring jtitle);

bool Print(JNIEnv* env, jobject obj);

+ // Called to get favicon of current tab, return null if no favicon is

+ // avaliable for current tab.

+ base::android::ScopedJavaLocalRef<jobject> GetFavicon(JNIEnv* env,

+ jobject obj);

// Register the Tab's native methods through JNI.

static bool RegisterTabAndroid(JNIEnv* env);