Implementation of GetFavicon for current tab.

chrome/browser/android/tab_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/tab_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/debug/trace_event.h"
 #include "chrome/browser/android/chrome_web_contents_delegate_android.h"
 #include "chrome/browser/browser_about_handler.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
+#include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/google/google_url_tracker_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/printing/print_view_manager_basic.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_android.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
@@ skipping 14 matching lines @@
 #include "components/google/core/browser/google_url_tracker.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/infobars/core/infobar_container.h"
 #include "components/url_fixer/url_fixer.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "jni/Tab_jni.h"
+#include "skia/ext/image_operations.h"
 #include "third_party/WebKit/public/platform/WebReferrerPolicy.h"
+#include "ui/gfx/android/java_bitmap.h"
+#include "ui/gfx/favicon_size.h"
 
 TabAndroid* TabAndroid::FromWebContents(content::WebContents* web_contents) {
   CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(web_contents);
   if (!core_tab_helper)
     return NULL;
 
   CoreTabHelperDelegate* core_delegate = core_tab_helper->delegate();
   if (!core_delegate)
     return NULL;
 
@@ skipping 450 matching lines @@
   printing::PrintViewManagerBasic::CreateForWebContents(web_contents());
   printing::PrintViewManagerBasic* print_view_manager =
       printing::PrintViewManagerBasic::FromWebContents(web_contents());
   if (print_view_manager == NULL)
     return false;
 
   print_view_manager->PrintNow();
   return true;
 }
 
+ScopedJavaLocalRef<jobject> TabAndroid::GetFavicon(JNIEnv* env, jobject obj) {
+  ScopedJavaLocalRef<jobject> bitmap;
+  FaviconTabHelper* favicon_tab_helper =
+      FaviconTabHelper::FromWebContents(web_contents_.get());
+  if (!favicon_tab_helper)
+    return bitmap;
+  if (!favicon_tab_helper->FaviconIsValid())
+    return bitmap;
+
+  SkBitmap favicon = favicon_tab_helper->GetFavicon().AsBitmap();
+
+  if (!favicon.isNull()) {
+    if (favicon.width() != gfx::kFaviconSize ||
+        favicon.height() != gfx::kFaviconSize)
+      favicon =
+          skia::ImageOperations::Resize(favicon,
+                                        skia::ImageOperations::RESIZE_BEST,
+                                        gfx::kFaviconSize,
+                                        gfx::kFaviconSize);
+    bitmap = gfx::ConvertToJavaBitmap(&favicon);

[David Trainor- moved to gerrit, 2014/07/09 20:34:51]

I think this is still incorrect.  It looks like you're not accounting for dpi. 
We want 16dp not 16px.

That's why you should use GetRepresentation.  We don't want to scale the 16x16
favicon up to 48x48 on xxhdpi it would look awful.

+  }
+  return bitmap;
+}
+
 prerender::PrerenderManager* TabAndroid::GetPrerenderManager() const {
   Profile* profile = GetProfile();
   if (!profile)
     return NULL;
   return prerender::PrerenderManagerFactory::GetForProfile(profile);
 }
 
 static void Init(JNIEnv* env, jobject obj) {
   TRACE_EVENT0("native", "TabAndroid::Init");
   // This will automatically bind to the Java object and pass ownership there.
   new TabAndroid(env, obj);
 }
 
 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }