Extend contextMenus API to support browser/page actions

chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h

Index: chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
diff --git a/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h b/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
index 773bd6249014a07855af73cdd2f518564e0e2e9c..8115ba2a51137b7776c700abb4bbc04bfe9b97b7 100644
--- a/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
+++ b/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
@@ -89,6 +89,12 @@ MenuItem::ContextList GetContexts(const PropertyWithEnumT& property) {
         // Not available for <webview>.
         contexts.Add(extensions::MenuItem::LAUNCHER);
         break;
+      case PropertyWithEnumT::CONTEXTS_TYPE_BROWSER_ACTION:
+        contexts.Add(extensions::MenuItem::BROWSER_ACTION);
+        break;
+      case PropertyWithEnumT::CONTEXTS_TYPE_PAGE_ACTION:
+        contexts.Add(extensions::MenuItem::PAGE_ACTION);
+        break;

[gpdavis, 2014/06/28 00:05:41]

This is the reason I added the browser_action and page_action strings to
web_views_internal.  I could probably add logic in here to determine what
PropertyWithEnumT is at the time this function is called, and only accommodate
for these cases if it's context_menu and not web_views_internal.  Seems like a
messy thing to do to such a clean function though.

What do you think?

       case PropertyWithEnumT::CONTEXTS_TYPE_NONE:
         NOTREACHED();
     }