Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3882)

Unified Diff: chrome/common/extensions/api/web_view_internal.json

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed AppendExtensionItemsImpl, minor cleanup, comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/web_view_internal.json
diff --git a/chrome/common/extensions/api/web_view_internal.json b/chrome/common/extensions/api/web_view_internal.json
index 94bf1802ddb0cc1dd6aa49b0402015ee2fb64d47..c09c1261be3e8eecf71c7411cdef64cc855b966c 100644
--- a/chrome/common/extensions/api/web_view_internal.json
+++ b/chrome/common/extensions/api/web_view_internal.json
@@ -124,7 +124,7 @@
"items": {
"type": "string",
// |launcher| isn't actually supported, this is listed here so that we can build |contexts| using the same code from chrome.contextMenus API.
- "enum": ["all", "page", "frame", "selection", "link", "editable", "image", "video", "audio", "launcher"]
+ "enum": ["all", "page", "frame", "selection", "link", "editable", "image", "video", "audio", "launcher", "browser_action", "page_action"]
Yoyo Zhou 2014/07/15 23:35:01 These don't make sense for webviews because: Webv
gpdavis 2014/07/16 01:11:10 Ah, I see. That makes sense. The only problem I
},
"minItems": 1,
"optional": true,
@@ -218,7 +218,7 @@
"items": {
"type": "string",
// |launcher| isn't actually supported, this is listed here so that we can build |contexts| using the same code from chrome.contextMenus API.
- "enum": ["all", "page", "frame", "selection", "link", "editable", "image", "video", "audio", "launcher"]
+ "enum": ["all", "page", "frame", "selection", "link", "editable", "image", "video", "audio", "launcher", "browser_action", "page_action"]
},
"minItems": 1,
"optional": true,

Powered by Google App Engine
This is Rietveld 408576698