chrome/browser/ui/app_list/app_context_menu.cc - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_context_menu.cc

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed AppendExtensionItemsImpl, minor cleanup, comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/render_view_context_menu.cc ('K') | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/ui/ash/launcher/launcher_context_menu.cc » ('j') | chrome/browser/ui/ash/launcher/launcher_context_menu.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_context_menu.cc

diff --git a/chrome/browser/ui/app_list/app_context_menu.cc b/chrome/browser/ui/app_list/app_context_menu.cc

index 5c454e26a82bbafe693d3979618c79298868aca8..f47ca617106270e11b28d285a7e1bccd99da8fee 100644

--- a/chrome/browser/ui/app_list/app_context_menu.cc

+++ b/chrome/browser/ui/app_list/app_context_menu.cc

@@ -153,7 +153,10 @@ ui::MenuModel* AppContextMenu::GetMenuModel() {

// Assign unique IDs to commands added by the app itself.

int index = USE_LAUNCH_TYPE_COMMAND_END;

extension_menu_items_->AppendExtensionItems(

- extensions::MenuItem::ExtensionKey(app_id_), base::string16(), &index);

+ extensions::MenuItem::ExtensionKey(app_id_),

+ base::string16(),

+ &index,

+ true); // include_icons

Yoyo Zhou 2014/07/15 23:35:00 ditto

gpdavis 2014/07/16 01:11:10 Done.

// If at least 1 item was added, add another separator after the list.

if (index > USE_LAUNCH_TYPE_COMMAND_END)