chrome/browser/extensions/context_menu_matcher.h - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/context_menu_matcher.h

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed AppendExtensionItemsImpl, minor cleanup, comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h ('k') | chrome/browser/extensions/context_menu_matcher.cc » ('j') | chrome/browser/extensions/extension_context_menu_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/context_menu_matcher.h

diff --git a/chrome/browser/extensions/context_menu_matcher.h b/chrome/browser/extensions/context_menu_matcher.h

index 782b8d3fd6db201fb1f20eb8746d37c25e67b1d6..798ff9dcae431d4210b9826e2f6000f40aac613e 100644

--- a/chrome/browser/extensions/context_menu_matcher.h

+++ b/chrome/browser/extensions/context_menu_matcher.h

@@ -33,10 +33,12 @@ class ContextMenuMatcher {

// This is a helper function to append items for one particular extension.

// The |index| parameter is used for assigning id's, and is incremented for

- // each item actually added.

+ // each item actually added. |include_icons| is used to determine whether

+ // the extension's icon should be included with the items.

Yoyo Zhou 2014/07/15 23:35:00 "included with the items": does that mean "shown"?

gpdavis 2014/07/16 01:11:10 Done.

void AppendExtensionItems(const MenuItem::ExtensionKey& extension_key,

const base::string16& selection_text,

- int* index);

+ int* index,

+ bool include_icons);

void Clear();