Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression …

runtime/vm/code_descriptors_test.cc

Index: runtime/vm/code_descriptors_test.cc
===================================================================
--- runtime/vm/code_descriptors_test.cc	(revision 37788)
+++ runtime/vm/code_descriptors_test.cc	(working copy)
@@ -257,9 +257,11 @@
   const PcDescriptors& descriptors =
       PcDescriptors::Handle(code.pc_descriptors());
   int call_count = 0;
-  for (int i = 0; i < descriptors.Length(); ++i) {
-    if (descriptors.DescriptorKind(i) == PcDescriptors::kUnoptStaticCall) {
-      stackmap_table_builder->AddEntry(descriptors.PC(i) - code.EntryPoint(),
+  PcDescriptors::Iterator iter(descriptors);

[siva, 2014/07/01 18:37:11]

Not for this CL but it might make things easier to have a kind
in the iterators.

e.g:
PcDescriptors::Iterator iter(descriptors,
                             PcDescriptors::kUnoptStaticCall);
const RawPcDescriptors::PcDescriptorRec* rec = iter.Next();
while (rec != NULL) {
   stackmap_table_builder->AddEntry(rec->pc - code.EntryPoint(),
                                    stack_bitmap,
                                    0);
   ++call_count;
}  

[srdjan, 2014/07/07 18:01:25]

I am planning either that, or specifying the kind in the call to Next.

+  while (iter.HasNext()) {
+    const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
+    if (rec.kind() == RawPcDescriptors::kUnoptStaticCall) {
+      stackmap_table_builder->AddEntry(rec.pc - code.EntryPoint(),
                                        stack_bitmap,
                                        0);
       ++call_count;