Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 356033002: DevTools: Get rid of WebInspector.debuggerModel in NetworkUISourceCodeProvider (Closed)

Created:
6 years, 6 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Get rid of WebInspector.debuggerModel in NetworkUISourceCodeProvider BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177097

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address vsevik's comments #

Total comments: 2

Patch Set 3 : Address vsevik's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -18 lines) Patch
M LayoutTests/http/tests/inspector/stylesheet-source-mapping.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html View 1 2 chunks +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js View 1 2 6 chunks +18 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sdk/Resource.js View 1 5 chunks +7 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sergeyv
6 years, 6 months ago (2014-06-26 12:52:01 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/356033002/diff/1/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js File Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js (right): https://chromiumcodereview.appspot.com/356033002/diff/1/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js#newcode137 Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js:137: var target = /** @type {!WebInspector.Target} */ (event.target.target()); please ...
6 years, 6 months ago (2014-06-26 13:11:33 UTC) #2
sergeyv
https://codereview.chromium.org/356033002/diff/1/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js File Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js (right): https://codereview.chromium.org/356033002/diff/1/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js#newcode137 Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js:137: var target = /** @type {!WebInspector.Target} */ (event.target.target()); On ...
6 years, 6 months ago (2014-06-26 14:56:00 UTC) #3
vsevik
lgtm https://codereview.chromium.org/356033002/diff/20001/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js File Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js (right): https://codereview.chromium.org/356033002/diff/20001/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js#newcode136 Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js:136: var target = /** @type {!WebInspector.Target} */ (event.target.target()); ...
6 years, 6 months ago (2014-06-26 15:42:08 UTC) #4
sergeyv
https://codereview.chromium.org/356033002/diff/20001/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js File Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js (right): https://codereview.chromium.org/356033002/diff/20001/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js#newcode136 Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js:136: var target = /** @type {!WebInspector.Target} */ (event.target.target()); On ...
6 years, 6 months ago (2014-06-27 11:19:32 UTC) #5
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-27 11:19:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/356033002/40001
6 years, 6 months ago (2014-06-27 11:20:02 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 12:27:50 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 12:35:30 UTC) #9
Message was sent while issue was closed. 
Change committed as 177097

Powered by Google App Engine
This is Rietveld 408576698