Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Issue 35563005: Added landing pages for new samples (Closed)

Created:
7 years, 2 months ago by shailentuli
Modified:
7 years, 2 months ago
Reviewers:
Kathy Walrath
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

Added landing pages for new samples R=kathyw@google.com Committed: 3f47a50

Patch Set 1 #

Patch Set 2 : Added samples to be released to yaml file #

Total comments: 45

Patch Set 3 : Numerous changes based on Kathy' #

Patch Set 4 : Tweak #

Total comments: 2

Patch Set 5 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -51 lines) Patch
.gitignore View 1 1 chunk +2 lines, -0 lines 0 comments Download
src/site/samples/anagram/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/appcache/index.markdown View 1 chunk +41 lines, -0 lines 0 comments Download
src/site/samples/countdown/index.markdown View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
src/site/samples/dnd/index.markdown View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
src/site/samples/dndfiles/index.markdown View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
src/site/samples/filesystem/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
src/site/samples/imagefilters/index.markdown View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
src/site/samples/indexeddb_todo/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/localstorage/example/packages/browser/dart.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
src/site/samples/localstorage/example/packages/browser/interop.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
src/site/samples/localstorage/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/notifications/index.markdown View 1 chunk +31 lines, -0 lines 0 comments Download
src/site/samples/raf/index.markdown View 1 chunk +1 line, -1 line 0 comments Download
src/site/samples/samples.css View 1 1 chunk +7 lines, -1 line 0 comments Download
src/site/samples/samples.yaml View 1 2 3 4 5 chunks +55 lines, -25 lines 0 comments Download
src/site/samples/slambook/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/solar/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/solar3d/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/stopwatch/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/terminal/index.markdown View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/todo/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/todo_with_delete/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/todomvc/index.markdown View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
src/site/samples/video/index.markdown View 1 chunk +28 lines, -0 lines 0 comments Download
src/site/samples/webaudio/index.markdown View 1 chunk +30 lines, -0 lines 0 comments Download
src/site/samples/websockets/index.markdown View 1 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shailentuli
Staged at: https://samples-dot-dart-lang.appspot.com/samples/ PTAL. Let's try to release these samples on Wednesday.
7 years, 2 months ago (2013-10-23 06:21:40 UTC) #1
Kathy Walrath
a bunch of nits, nothing major https://chromiumcodereview.appspot.com/35563005/diff/20001/src/site/samples/appcache/index.markdown File src/site/samples/appcache/index.markdown (right): https://chromiumcodereview.appspot.com/35563005/diff/20001/src/site/samples/appcache/index.markdown#newcode1 src/site/samples/appcache/index.markdown:1: --- I don't ...
7 years, 2 months ago (2013-10-23 15:41:05 UTC) #2
shailentuli
Staged version at: https://samples-dot-dart-lang.appspot.com/samples/ https://chromiumcodereview.appspot.com/35563005/diff/20001/src/site/samples/appcache/index.markdown File src/site/samples/appcache/index.markdown (right): https://chromiumcodereview.appspot.com/35563005/diff/20001/src/site/samples/appcache/index.markdown#newcode1 src/site/samples/appcache/index.markdown:1: --- On 2013/10/23 15:41:05, Kathy ...
7 years, 2 months ago (2013-10-23 17:36:56 UTC) #3
Kathy Walrath
lgtm a couple of capitalization nits it'd be nice to fix. https://chromiumcodereview.appspot.com/35563005/diff/240001/src/site/samples/imagefilters/index.markdown File src/site/samples/imagefilters/index.markdown (right): ...
7 years, 2 months ago (2013-10-23 18:47:39 UTC) #4
shailentuli
7 years, 2 months ago (2013-10-23 20:27:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r3f47a50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698