infra/libs/git2/__init__.py - Issue 355153002: Refactor infra git libs and testing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/libs/git2/init.py

Issue 355153002: Refactor infra git libs and testing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra@fake_testing_support

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from infra.libs.git2.util import INVALID
	Vadim Sh. 2014/06/27 18:26:22 why git2? :) Do we have git 1 in infra/infra? Alte why git2? :) Do we have git 1 in infra/infra? Alternatives: 'git', 'gitlib'.. dunno. agable 2014/06/27 18:53:11 Agreed -- I think now is the time to absorb git in Show quoted text On 2014/06/27 18:26:22, Vadim Sh. wrote: > why git2? :) Do we have git 1 in infra/infra? Alternatives: 'git', 'gitlib'.. > dunno. Agreed -- I think now is the time to absorb git into these, and fix lkgr-finder to use these instead. iannucci 2014/06/28 08:33:35 I'd rather do in a followup CL. AFAIK, neither lkg Show quoted text On 2014/06/27 18:53:11, agable wrote: > On 2014/06/27 18:26:22, Vadim Sh. wrote: > > why git2? :) Do we have git 1 in infra/infra? Alternatives: 'git', 'gitlib'.. > > dunno. > > Agreed -- I think now is the time to absorb git into these, and fix lkgr-finder > to use these instead. I'd rather do in a followup CL. AFAIK, neither lkgr nor git have any tests, so I'd rather refactor them separately (preferably after, you know, adding tests :p).
	6 from infra.libs.git2.util import CalledProcessError

	7

	8 from infra.libs.git2.git2 import Commit

	9 from infra.libs.git2.git2 import Ref

	10 from infra.libs.git2.git2 import Repo
	agable 2014/06/27 18:53:11 Inconsistent between listing these all on their ow Inconsistent between listing these all on their own lines vs. all on one line as you do in data_structures/ and decorators/. iannucci 2014/06/28 08:33:35 I'm torn, but looks like google python style says Show quoted text On 2014/06/27 18:53:11, agable wrote: > Inconsistent between listing these all on their own lines vs. all on one line as > you do in data_structures/ and decorators/. I'm torn, but looks like google python style says 1/line, so I'll do that: http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Import...
	11

	12 from infra.libs.git2 import data

OLD	NEW

« infra/libs/decorators/decorators.py ('K') | « infra/libs/decorators/test/decorators_test.py ('k') | infra/libs/git2/config_ref.py » ('j') | infra/libs/git2/config_ref.py » ('J')

Side by Side Diff: infra/libs/git2/__init__.py

Side by Side Diff: infra/libs/git2/init.py