Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: scripts/slave/unittests/expect_tests/cover.py

Issue 355143002: Set coverage path globs on a per-Test basis instead of in main(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: fix _covers Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/unittests/expect_tests/__init__.py ('k') | scripts/slave/unittests/expect_tests/main.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/unittests/expect_tests/cover.py
diff --git a/scripts/slave/unittests/expect_tests/cover.py b/scripts/slave/unittests/expect_tests/cover.py
index aa09a788f9f8967014e7bb6473097b9b1b48e186..0180e1fc8a465d266eb841c329fd53efdb37cdb6 100644
--- a/scripts/slave/unittests/expect_tests/cover.py
+++ b/scripts/slave/unittests/expect_tests/cover.py
@@ -15,10 +15,18 @@ class _Cover(object):
self.kwargs = maybe_kwargs or {}
self.c = None
+ def __call__(self, **kwargs):
+ new_kwargs = self.kwargs
+ if self.enabled:
+ new_kwargs = new_kwargs.copy()
+ new_kwargs.update(kwargs)
+ return _Cover(self.enabled, new_kwargs)
+
def __enter__(self):
if self.enabled:
- self.c = coverage.coverage(**self.kwargs)
- self.c._warn_no_data = False
+ if self.c is None:
+ self.c = coverage.coverage(**self.kwargs)
+ self.c._warn_no_data = False
self.c.start()
def __exit__(self, *_):
@@ -28,19 +36,15 @@ class _Cover(object):
class CoverageContext(object):
- def __init__(self, name, includes, omits, cover_branches, html_report,
- extra_coverage_data, enabled=True):
+ def __init__(self, name, cover_branches, html_report, enabled=True):
self.opts = None
self.cov = None
self.enabled = enabled
self.html_report = html_report
- self.extra_data = extra_coverage_data or ()
if enabled:
self.opts = {
- 'include': includes,
- 'omit': omits,
'data_file': '.%s_coverage' % name,
'data_suffix': True,
'branch': cover_branches,
@@ -56,18 +60,6 @@ class CoverageContext(object):
fail = False
if self.enabled:
- include_files = set()
- for datafile in self.extra_data:
- # pylint: disable=W0212
- lines, arcs = self.cov.data._read_file(datafile)
- self.cov.data.add_line_data(lines)
- self.cov.data.add_arc_data(arcs)
- include_files.update(lines)
- include_files.update(arcs)
-
- self.cov.config.include = list(
- set(self.cov.config.include) | include_files)
-
if self.html_report:
self.cov.html_report(directory=self.html_report)
« no previous file with comments | « scripts/slave/unittests/expect_tests/__init__.py ('k') | scripts/slave/unittests/expect_tests/main.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698