Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3833)

Unified Diff: chrome/common/extensions/api/app_view_internal.json

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton
Patch Set: Added tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/app_view_internal.json
diff --git a/chrome/common/extensions/api/guest_view_internal.json b/chrome/common/extensions/api/app_view_internal.json
similarity index 60%
copy from chrome/common/extensions/api/guest_view_internal.json
copy to chrome/common/extensions/api/app_view_internal.json
index 50f9ab74f723d577e85a88338e86b5f3f0563261..5a52b40f06735557326afc71de8a3aff705c254a 100644
--- a/chrome/common/extensions/api/guest_view_internal.json
+++ b/chrome/common/extensions/api/app_view_internal.json
@@ -4,34 +4,30 @@
[
{
- "namespace": "guestViewInternal",
+ "namespace": "appViewInternal",
"compiler_options": {
- "implemented_in": "chrome/browser/extensions/api/guest_view/guest_view_internal_api.h"
+ "implemented_in": "chrome/browser/extensions/api/guest_view/app_view_internal_api.h"
},
"description": "none",
"functions": [
{
- "name": "createGuest",
+ "name": "attachFrame",
"type": "function",
lazyboy 2014/07/07 21:34:44 Please add a description of what this function doe
Fady Samuel 2014/07/08 15:47:09 Done.
"parameters": [
{
"type": "string",
- "name": "viewType",
+ "name": "url",
"nodoc": true
},
{
- "type": "object",
- "name": "createParams",
- "properties": {
- "storagePartitionId": {
- "type": "string",
- "optional": true
- }
- }
+ "type": "integer",
+ "name": "guestInstanceId",
+ "nodoc": true
},
{
"type": "function",
"name": "callback",
+ "optional": true,
"parameters": [
{
"type": "integer",
@@ -40,7 +36,19 @@
]
}
]
+ },
+ {
+ "name": "denyRequest",
+ "type": "function",
lazyboy 2014/07/07 21:34:44 Same as above, add description of this function.
Fady Samuel 2014/07/08 15:47:09 Done.
+ "parameters": [
+ {
+ "type": "integer",
+ "name": "guestInstanceId",
+ "nodoc": true
+ }
+ ]
}
]
}
]
+

Powered by Google App Engine
This is Rietveld 408576698