chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js - Issue 354483004: Implement <appview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js

Issue 354483004: Implement <appview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Addressed comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/app_view.js ('K') | « chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.html ('k') | chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/manifest.json » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js

diff --git a/chrome/test/data/extensions/platform_apps/ephemeral_apps/filesystem_retain_entries/main.js b/chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js

similarity index 62%

copy from chrome/test/data/extensions/platform_apps/ephemeral_apps/filesystem_retain_entries/main.js

copy to chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js

index f9e810e42ff1bd622db77616104cfe0089f1abc7..a9c0d2c95ddb169a348ddbe1ddcdb0761dad0895 100644

--- a/chrome/test/data/extensions/platform_apps/ephemeral_apps/filesystem_retain_entries/main.js

+++ b/chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-chrome.app.runtime.onLaunched.addListener(function() {

- chrome.app.window.create('index.html', {});

+chrome.app.runtime.onAppEmbeddingRequest.addListener(function(request) {

+ request.allow('main.html');

lazyboy 2014/07/08 18:24:34 what happens if we call request.deny() right after

Fady Samuel 2014/07/08 20:23:46 Nothing. The first call works, the second is disca

});