Implement <appview>

content/renderer/browser_plugin/browser_plugin.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 251 matching lines @@
       new BrowserPluginHostMsg_SetAutoSize(render_view_routing_id_,
                                            guest_instance_id_,
                                            auto_size_params,
                                            resize_guest_params));
 }
 
 void BrowserPlugin::Attach(int guest_instance_id,
                            scoped_ptr<base::DictionaryValue> extra_params) {
   CHECK(guest_instance_id != browser_plugin::kInstanceIDNone);
 
-  // If this BrowserPlugin is already attached to a guest, then do nothing.
-  if (HasGuestInstanceID())
-    return;
+  // If this BrowserPlugin is already attached to a guest, then kill the guest.
+  if (HasGuestInstanceID()) {
+    guest_crashed_ = false;
+    EnableCompositing(false);
+    if (compositing_helper_) {
+      compositing_helper_->OnContainerDestroy();
+      compositing_helper_ = NULL;
+    }
+    browser_plugin_manager()->RemoveBrowserPlugin(guest_instance_id_);
+    browser_plugin_manager()->Send(new BrowserPluginHostMsg_PluginDestroyed(
+        render_view_routing_id_, guest_instance_id_));

[lazyboy, 2014/07/08 18:24:34]

DCHECK_NE(guest_instance_id_, guest_instance_id)?

[Fady Samuel, 2014/07/08 20:23:46]

I just added an early exit in this case. There's nothing particularly useful we
can do here. Reattaching to the same guest doesn't make snese. 

+  }
 
   // This API may be called directly without setting the src attribute.
   // In that case, we need to make sure we don't allocate another instance ID.
   guest_instance_id_ = guest_instance_id;
   browser_plugin_manager()->AddBrowserPlugin(guest_instance_id, this);
 
   BrowserPluginHostMsg_Attach_Params attach_params;
   attach_params.focused = ShouldGuestBeFocused();
   attach_params.visible = visible_;
   attach_params.opaque = !GetAllowTransparencyAttribute();
@@ skipping 668 matching lines @@
     const blink::WebMouseEvent& event) {
   browser_plugin_manager()->Send(
       new BrowserPluginHostMsg_HandleInputEvent(render_view_routing_id_,
                                                 guest_instance_id_,
                                                 plugin_rect_,
                                                 &event));
   return true;
 }
 
 }  // namespace content