Implement <appview> skeleton.

Implement <appview> skeleton.

This CL implements a skeleton for <appview>. It includes the <appview>
custom element and AppViewGuest.

AppView is behind a flag --enable-app-view

BUG=364141
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281217

[lazyboy, 2014-06-27 04:14:02]

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/app/generated_...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/app/generated_...
chrome/app/generated_resources.grd:6334: +        Enable the AppView element in
Chrome Apps.
Probably <appview> element?

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/renderer/resou...
File chrome/renderer/resources/extensions/app_view.js (right):

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/renderer/resou...
chrome/renderer/resources/extensions/app_view.js:24: * @private
Let's not add @private annotations, I'm trying to get rid of them from
web_view.js, seems this is google style only, not chromium style.

https://chromiumcodereview.appspot.com/353013007/diff/1/extensions/renderer/d...
File extensions/renderer/dispatcher.cc (right):

https://chromiumcodereview.appspot.com/353013007/diff/1/extensions/renderer/d...
extensions/renderer/dispatcher.cc:834:
blink::WebCustomElement::addEmbedderCustomElementName("app-plugin");
Do we need this whitelist as it already contains a dash?

[Fady Samuel, 2014-06-27 16:11:00]

PTAL

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/app/generated_...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/app/generated_...
chrome/app/generated_resources.grd:6334: +        Enable the AppView element in
Chrome Apps.
On 2014/06/27 04:14:02, lazyboy wrote:
> Probably <appview> element?

Done.

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/renderer/resou...
File chrome/renderer/resources/extensions/app_view.js (right):

https://chromiumcodereview.appspot.com/353013007/diff/1/chrome/renderer/resou...
chrome/renderer/resources/extensions/app_view.js:24: * @private
On 2014/06/27 04:14:02, lazyboy wrote:
> Let's not add @private annotations, I'm trying to get rid of them from
> web_view.js, seems this is google style only, not chromium style.

Done.

https://chromiumcodereview.appspot.com/353013007/diff/1/extensions/renderer/d...
File extensions/renderer/dispatcher.cc (right):

https://chromiumcodereview.appspot.com/353013007/diff/1/extensions/renderer/d...
extensions/renderer/dispatcher.cc:834:
blink::WebCustomElement::addEmbedderCustomElementName("app-plugin");
On 2014/06/27 04:14:02, lazyboy wrote:
> Do we need this whitelist as it already contains a dash?

I got rid of the dash.

[lazyboy, 2014-06-27 16:21:28]

lgtm

[lazyboy, 2014-06-27 16:21:29]

lgtm

lgtm

[not at google - send to devlin, 2014-06-27 17:32:20]

https://chromiumcodereview.appspot.com/353013007/diff/20001/chrome/renderer/e...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://chromiumcodereview.appspot.com/353013007/diff/20001/chrome/renderer/e...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:304: }
questions:
- why is this different logic to webview?
- what about "denyAppView"?
and please add a big todo somewhere; eagerly calling Request on context startup
is expensive, it would be better if there were a lightweight way of detecting
when an adview (or webview) is created and only then set up the infrastructure.
don't custom elements give you a way to do that?

this comment should go at the top of RequireAdditionalModels.

https://chromiumcodereview.appspot.com/353013007/diff/20001/extensions/render...
File extensions/renderer/dispatcher.cc (right):

https://chromiumcodereview.appspot.com/353013007/diff/20001/extensions/render...
extensions/renderer/dispatcher.cc:834:
blink::WebCustomElement::addEmbedderCustomElementName("appplugin");
ppp looks funny :)

[Fady Samuel, 2014-06-27 18:14:32]

PTAL

https://codereview.chromium.org/353013007/diff/20001/chrome/renderer/extensio...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/353013007/diff/20001/chrome/renderer/extensio...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:304: }
On 2014/06/27 17:32:19, kalman wrote:
> questions:
> - why is this different logic to webview?

1. <webview> will work in unblessed contexts in the near feature (in component
extensions on WebUI pages). No immediate plans to support this for appview.
<webview> also has experimental features that are white listed. <appview> does
not.



> - what about "denyAppView"?

Good point. Added.

> and please add a big todo somewhere; eagerly calling Request on context
startup
> is expensive, it would be better if there were a lightweight way of detecting
> when an adview (or webview) is created and only then set up the
infrastructure.
> don't custom elements give you a way to do that?
> 
> this comment should go at the top of RequireAdditionalModels.

I'm not sure how to do that but I can investigate in a separate patch.

https://codereview.chromium.org/353013007/diff/20001/extensions/renderer/disp...
File extensions/renderer/dispatcher.cc (right):

https://codereview.chromium.org/353013007/diff/20001/extensions/renderer/disp...
extensions/renderer/dispatcher.cc:834:
blink::WebCustomElement::addEmbedderCustomElementName("appplugin");
On 2014/06/27 17:32:19, kalman wrote:
> ppp looks funny :)

Fortunately, an internal custom element (that we use for observing attribute
changes) that the developer will never see.

[Fady Samuel, 2014-06-27 18:15:44]

PTAL kalman@

[not at google - send to devlin, 2014-06-27 18:16:17]

https://codereview.chromium.org/353013007/diff/20001/chrome/renderer/extensio...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/353013007/diff/20001/chrome/renderer/extensio...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:304: }
On 2014/06/27 18:14:31, Fady Samuel wrote:
> On 2014/06/27 17:32:19, kalman wrote:
> > questions:
> > - why is this different logic to webview?
> 
> 1. <webview> will work in unblessed contexts in the near feature (in component
> extensions on WebUI pages). No immediate plans to support this for appview.
> <webview> also has experimental features that are white listed. <appview> does
> not.

So the "unblessed" isn't needed yet? can we take that out (in a separate CL)
because there are better ways to implement this for webui.

> 
> 
> 
> > - what about "denyAppView"?
> 
> Good point. Added.
> 
> > and please add a big todo somewhere; eagerly calling Request on context
> startup
> > is expensive, it would be better if there were a lightweight way of
detecting
> > when an adview (or webview) is created and only then set up the
> infrastructure.
> > don't custom elements give you a way to do that?
> > 
> > this comment should go at the top of RequireAdditionalModels.
> 
> I'm not sure how to do that but I can investigate in a separate patch.

thanks.

[not at google - send to devlin, 2014-06-27 18:17:11]

oh, lgtm

[Fady Samuel, 2014-06-27 18:18:22]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-06-27 18:20:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/353013007/40001

[Fady Samuel, 2014-06-27 19:07:12]

+jam@ for:

chrome/renderer/chrome_content_renderer_client.cc
chrome/renderer/resources/renderer_resources.grd

Thanks!

[commit-bot: I haz the power, 2014-06-27 21:34:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-27 21:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-27 21:37:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[jam, 2014-06-30 16:02:58]

lgtm

[Fady Samuel, 2014-07-02 14:47:57]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-07-02 14:49:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/353013007/60001

[commit-bot: I haz the power, 2014-07-02 20:50:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-02 20:57:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 20:57:20]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Fady Samuel, 2014-07-02 22:02:06]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-07-02 22:02:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/353013007/60001

[commit-bot: I haz the power, 2014-07-02 22:31:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-02 22:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 22:42:04]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Fady Samuel, 2014-07-03 03:10:27]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-07-03 03:13:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/353013007/60001

[commit-bot: I haz the power, 2014-07-03 07:49:14]

Change committed as 281217