Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6734)

Unified Diff: Source/devtools/front_end/sdk/ResourceScriptMapping.js

Issue 352953002: DevTools: properly support targets in LiveEditSupport (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix live edit Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/ResourceScriptMapping.js
diff --git a/Source/devtools/front_end/sdk/ResourceScriptMapping.js b/Source/devtools/front_end/sdk/ResourceScriptMapping.js
index afa717cf37d669caac0f66163e489c08ec833d21..09b6ff72df834c490a6893987c6ac2f0f50dd6a0 100644
--- a/Source/devtools/front_end/sdk/ResourceScriptMapping.js
+++ b/Source/devtools/front_end/sdk/ResourceScriptMapping.js
@@ -276,6 +276,7 @@ WebInspector.ResourceScriptFile.prototype = {
*/
commitLiveEdit: function(callback)
{
+ var target = this._resourceScriptMapping._target;
/**
* @param {?string} error
* @param {!DebuggerAgent.SetScriptSourceError=} errorData
@@ -285,7 +286,7 @@ WebInspector.ResourceScriptFile.prototype = {
{
if (error) {
this._update();
- WebInspector.LiveEditSupport.logDetailedError(error, errorData, this._script);
+ WebInspector.LiveEditSupport.logDetailedError(target, error, errorData, this._script);
if (callback)
callback(false);
return;
@@ -293,14 +294,14 @@ WebInspector.ResourceScriptFile.prototype = {
this._scriptSource = source;
this._update();
- WebInspector.LiveEditSupport.logSuccess();
+ WebInspector.LiveEditSupport.logSuccess(target);
vsevik 2014/06/26 13:07:29 Let's make a message per live edit, not per target
sergeyv 2014/06/26 14:08:40 Done.
if (callback)
callback(true);
}
if (!this._script)
return;
var source = this._uiSourceCode.workingCopy();
- this._resourceScriptMapping._debuggerModel.setScriptSource(this._script.scriptId, source, innerCallback.bind(this));
+ target.debuggerModel.setScriptSource(this._script.scriptId, source, innerCallback.bind(this));
},
/**

Powered by Google App Engine
This is Rietveld 408576698