Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 352953002: DevTools: properly support targets in LiveEditSupport (Closed)

Created:
6 years, 6 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: properly support targets in LiveEditSupport BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177096

Patch Set 1 #

Patch Set 2 : Fix live edit #

Total comments: 4

Patch Set 3 : Address vsevik's comments #

Total comments: 10

Patch Set 4 : Address vsevik's comments #

Patch Set 5 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -32 lines) Patch
M LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DebuggerScriptMapping.js View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/DefaultScriptMapping.js View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/LiveEditSupport.js View 1 2 3 4 chunks +30 lines, -9 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceScriptMapping.js View 1 2 2 chunks +6 lines, -13 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 2 3 4 2 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sergeyv
6 years, 6 months ago (2014-06-26 11:36:29 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/352953002/diff/20001/Source/devtools/front_end/sdk/ResourceScriptMapping.js File Source/devtools/front_end/sdk/ResourceScriptMapping.js (right): https://chromiumcodereview.appspot.com/352953002/diff/20001/Source/devtools/front_end/sdk/ResourceScriptMapping.js#newcode297 Source/devtools/front_end/sdk/ResourceScriptMapping.js:297: WebInspector.LiveEditSupport.logSuccess(target); Let's make a message per live edit, ...
6 years, 6 months ago (2014-06-26 13:07:29 UTC) #2
sergeyv
https://codereview.chromium.org/352953002/diff/20001/Source/devtools/front_end/sdk/ResourceScriptMapping.js File Source/devtools/front_end/sdk/ResourceScriptMapping.js (right): https://codereview.chromium.org/352953002/diff/20001/Source/devtools/front_end/sdk/ResourceScriptMapping.js#newcode297 Source/devtools/front_end/sdk/ResourceScriptMapping.js:297: WebInspector.LiveEditSupport.logSuccess(target); On 2014/06/26 17:07:29, vsevik wrote: > Let's make ...
6 years, 6 months ago (2014-06-26 14:08:40 UTC) #3
vsevik
https://codereview.chromium.org/352953002/diff/40001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/352953002/diff/40001/Source/devtools/front_end/sdk/Target.js#newcode152 Source/devtools/front_end/sdk/Target.js:152: this.liveEditSupport = new WebInspector.LiveEditSupport(this, WebInspector.workspace); Let's move this to ...
6 years, 6 months ago (2014-06-26 14:16:20 UTC) #4
sergeyv
https://codereview.chromium.org/352953002/diff/40001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/352953002/diff/40001/Source/devtools/front_end/sdk/Target.js#newcode152 Source/devtools/front_end/sdk/Target.js:152: this.liveEditSupport = new WebInspector.LiveEditSupport(this, WebInspector.workspace); On 2014/06/26 18:16:19, vsevik ...
6 years, 6 months ago (2014-06-26 14:38:35 UTC) #5
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-26 14:38:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/352953002/60001
6 years, 6 months ago (2014-06-26 14:39:53 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-26 15:49:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 16:13:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/13481)
6 years, 6 months ago (2014-06-26 16:13:55 UTC) #10
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-06-27 11:29:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/352953002/80001
6 years, 5 months ago (2014-06-27 11:30:03 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 12:34:50 UTC) #13
Message was sent while issue was closed. 
Change committed as 177096

Powered by Google App Engine
This is Rietveld 408576698