Fix package relative imports

Fix package relative imports

We're subtly inconsistent with the spec (and the command-line VM and
dart2js) on how we handle relative imports in packages.  See referenced bug.

BUG=http://dartbug.com/17662
R=ahe@google.com, jacobr@google.com

Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=176820

[vsm, 2014-06-23 07:31:09]

Peter: This fixes the 3 tests you marked fail.  I'll send a corresponding CL for
that.

[ahe, 2014-06-23 16:05:50]

I'm not sure I'm really qualified to review this. But as far as I can tell: LGTM

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
File Source/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
Source/bindings/dart/DartUtilities.cpp:1112: // convert back.
Interesting approach. As far as I can tell, Chrome doesn't try to rewrite URIs
like http://_//fisk.txt and file://_//fisk.txt.  However, http:////fisk.txt and
file:////fisk.txt lead to unexpected results where slashes are dropped.

In other words, it seems like the "_" ensures that this trick works for both:

package:/foo...

and

package:foo...

So that's good :-)

[Jacob, 2014-06-23 16:42:27]

lgtm

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
File Source/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
Source/bindings/dart/DartUtilities.cpp:1111: // "package:<path>", we convert to
"package://_/<path>" for resolution and
nit: keep commend at 80 chars.

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
Source/bindings/dart/DartUtilities.cpp:1115: DEFINE_STATIC_LOCAL(const int,
resolvePrefixLength, (strlen(resolvePrefix)));
instead of defining static locals for the string and the length 
consider
DEFINE_STATIC_LOCAL(String, resolvePrefix, ("package://_/"))

getting the length from the string object should be O(1) as well and the code
will be a bit more terse.

[vsm, 2014-06-24 07:16:02]

Committed patchset #2 manually as r176820 (presubmit successful).

[vsm, 2014-06-24 07:16:28]

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
File Source/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
Source/bindings/dart/DartUtilities.cpp:1111: // "package:<path>", we convert to
"package://_/<path>" for resolution and
On 2014/06/23 16:42:27, Jacob wrote:
> nit: keep commend at 80 chars.

Done.

https://chromiumcodereview.appspot.com/350653002/diff/1/Source/bindings/dart/...
Source/bindings/dart/DartUtilities.cpp:1115: DEFINE_STATIC_LOCAL(const int,
resolvePrefixLength, (strlen(resolvePrefix)));
On 2014/06/23 16:42:27, Jacob wrote:
> instead of defining static locals for the string and the length 
> consider
> DEFINE_STATIC_LOCAL(String, resolvePrefix, ("package://_/"))
> 
> getting the length from the string object should be O(1) as well and the code
> will be a bit more terse.

Done.