Issue 350153004: DevTools: Activate breakpoints in breakpointManager

Issue 350153004: DevTools: Activate breakpoints in breakpointManager (Closed)

Created:
6 years, 6 months ago by sergeyv

Modified:
6 years, 5 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Activate breakpoints in breakpointManager BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177057

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address vsevik's comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -44 lines)			Patch
M	LayoutTests/http/tests/inspector/debugger-test.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/sources/debugger/debugger-breakpoints-not-activated-on-reload.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/BreakpointManager.js	View	1	6 chunks	+43 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/sdk/DebuggerModel.js	View	1	3 chunks	+0 lines, -22 lines	0 comments	Download
M	Source/devtools/front_end/sources/BreakpointsSidebarPane.js	View		3 chunks	+13 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/sources/SourcesPanel.js	View	1	6 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm with a nit https://chromiumcodereview.appspot.com/350153004/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://chromiumcodereview.appspot.com/350153004/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode704 Source/devtools/front_end/sources/SourcesPanel.js:704: WebInspector.breakpointManager.toggleBreakpointsActive(); Let's inline toggleBreakpointsActive.

6 years, 6 months ago (2014-06-26 12:46:35 UTC) #2

sergeyv

https://codereview.chromium.org/350153004/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/350153004/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode704 Source/devtools/front_end/sources/SourcesPanel.js:704: WebInspector.breakpointManager.toggleBreakpointsActive(); On 2014/06/26 12:46:35, vsevik wrote: > Let's inline ...

6 years, 6 months ago (2014-06-26 13:00:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/350153004/20001

6 years, 6 months ago (2014-06-26 13:02:07 UTC) #5

Message was sent while issue was closed.

Change committed as 177057

Expand Messages | Collapse Messages