Added support for git cl upload automatic trybot determination.

tests/git_cl_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for git_cl.py."""
 
 import os
 import StringIO
 import stat
 import sys
 import unittest
+import re
 
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 from testing_support.auto_stub import TestCase
 
 import git_cl
 import git_common
 import subprocess2
-
+import presubmit_support
 
 class PresubmitMock(object):
   def __init__(self, *args, **kwargs):
     self.reviewers = []
   @staticmethod
   def should_continue():
     return True
 
 
 class RietveldMock(object):
@@ skipping 711 matching lines @@
       ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
     ]
     expected = [i[2] for i in data]
     actual = []
     for orig, reviewers, _expected in data:
       obj = git_cl.ChangeDescription(orig)
       obj.update_reviewers(reviewers)
       actual.append(obj.description)
     self.assertEqual(expected, actual)
 
+  def test_trybots_from_PRESUBMIT(self):
+    TEST_MASTER = 'testMaster'
+    TEST_BUILDER = 'testBuilder'
+    MASTERS = {TEST_MASTER:{TEST_BUILDER:['a']}}
+    self.mock(presubmit_support, 'DoGetTryMasters',
+              lambda *args: MASTERS)
+
+    change_mock = ChangeMock()
+    changelist_mock = ChangelistMock(change_mock)
+    self.mock(git_cl, 'is_dirty_git_tree', lambda x: False)
+    self.mock(git_cl, 'print_stats', lambda *arg: True)
+    self.mock(git_cl, 'Changelist',  lambda *args: changelist_mock)
+    self.mock(git_cl, 'CreateDescriptionFromLog', lambda arg: 'Commit message')
+    self.mock(git_cl.ChangeDescription, 'prompt', lambda self: None)
+
+    self.calls = [
+        ((['git', 'config', 'rietveld.autoupdate',],),
+         ''),
+        ((['git', 'config', 'gerrit.host',],),
+         ''),
+        ((['git', 'rev-parse', '--show-cdup',],),
+         ''),
+        ((['git', 'config', 'rietveld.private',],),
+         ''),
+        ((['git', 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
+         ''),
+        ((['git', 'config', 'rietveld.project',],),
+         ''),
+        ((['git', 'rev-parse', 'HEAD',],),
+         ''),
+        ]
+
+    stored_description = []
+    def check_upload(args):
+      i = 0
+      for arg in args:
+        if arg == '--message':
+          break
+        i += 1
+
+      self.assertTrue(i < len(args))
+      stored_description.append(args[i+1])
+      return 1, 2
+    self.mock(git_cl.upload, 'RealMain', check_upload)
+
+    git_cl.main(['upload', '--bypass-hooks', '--auto-bots'])
+    found = re.search("CQ_TRYBOTS=(.*?)$", stored_description[0])
+    self.assertTrue(found)
+    self.assertEqual(found.group(1), '%s:%s;' % (TEST_MASTER, TEST_BUILDER))
+
+
+class ChangelistMock(object):
+  def __init__(self, change_mock):
+    self.change_mock = change_mock
+
+  def __getattr__(self, key):
+    if key == 'GetChange':
+      return lambda *args: self.change_mock
+    if key == 'SetWatchers':
+      return lambda *args: None
+    if 'Set' in key:
+      return lambda x: True

[iannucci, 2014/06/24 23:23:59]

these should be methods :D

[martiniss, 2014/06/24 23:55:55]

Done! Manually added all the mocked methods.

+    return lambda: []
+
+class ChangeMock(object):
+  def __init__(self):
+    self.stored_description = None
+
+  def __getattr__(self, key):
+    if key == 'SetDescriptionText':
+      def func(description):
+        self.stored_description = description
+      return func
+    if key == 'FullDescriptionText':
+      return lambda: "HIHI TEST DESCRIPTION"
+    if 'Repository' in key:
+      return lambda: ''
+    return lambda: []
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(
       level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
   unittest.main()