Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: mojo/environment/BUILD.gn

Issue 346613004: Use loadable module instead of shared library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Follow review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/mojo_common_export.h ('k') | mojo/environment/default_async_waiter_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/environment/BUILD.gn
diff --git a/mojo/environment/BUILD.gn b/mojo/environment/BUILD.gn
index d25a94d58ea3184d9bc83c44333f52ec6b65b24d..820e7c35cf3f0b5681a0548a965459cbc01867e1 100644
--- a/mojo/environment/BUILD.gn
+++ b/mojo/environment/BUILD.gn
@@ -7,36 +7,14 @@ static_library("chromium") {
output_name = "mojo_environment_chromium"
sources = [
- "environment.cc",
- # TODO(vtl): This is kind of ugly. (See TODO in logging.h.)
- "../public/cpp/environment/logging.h",
- "../public/cpp/environment/lib/logging.cc",
- ]
-
- deps = [
- ":chromium_impl",
- "//mojo/common",
- ]
-
- forward_dependent_configs_from = [
- ":chromium_impl",
- ]
-}
-
-# GYP version: mojo.gyp:mojo_environment_chromium_impl
-component("chromium_impl") {
- output_name = "mojo_environment_impl"
- visibility = "//mojo/*"
-
- sources = [
"default_async_waiter_impl.cc",
"default_async_waiter_impl.h",
"default_logger_impl.cc",
"default_logger_impl.h",
- ]
-
- defines = [
- "MOJO_ENVIRONMENT_IMPL_IMPLEMENTATION",
+ "environment.cc",
+ # TODO(vtl): This is kind of ugly. (See TODO in logging.h.)
+ "../public/cpp/environment/logging.h",
+ "../public/cpp/environment/lib/logging.cc",
]
deps = [
« no previous file with comments | « mojo/common/mojo_common_export.h ('k') | mojo/environment/default_async_waiter_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698