Use loadable module instead of shared library.

Use loadable module instead of shared library.

This also split the common and environment library, so that standalone application do not depend on system_impl anymore.

This allows the mojo shell to run on non component build.

R=viettrungluu@chromium.org

[viettrungluu, 2014-06-19 04:09:19]

Hrm, doesn't appear to build yet (Mac, linux_chromium_clang_dbg)....

[qsr, 2014-06-30 14:14:34]

Fix gyp syntax

[qsr, 2014-06-30 15:29:43]

viettrungluu@ -> This seems now ready to review.
tim@ -> FYI

[viettrungluu, 2014-06-30 16:27:18]

+beng for geometry and input events (I think it's okay, esp. since those
libraries only consist of type converters; it might be suboptimal if the
libraries get bigger)

https://codereview.chromium.org/346613004/diff/660001/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://codereview.chromium.org/346613004/diff/660001/mojo/mojo.gyp#newcode19
mojo/mojo.gyp:19: 'common_sources': [
Probably you should have a comment explaining why we have variables for these.
Something like: "We build two versions of these libraries, a version for use in
Chromium and the shell and an "embedded" version for use in loadable
apps/services.".

https://codereview.chromium.org/346613004/diff/660001/mojo/mojo.gyp#newcode349
mojo/mojo.gyp:349: 'target_name': 'mojo_common_embedded_lib',
It'd be nice if the non-embedded and embedded versions were in the same order in
the .gyp file (e.g., non-embedded, then embedded).

You should also have comments before each along the lines of "For use in
Chromium and the shell."/"For use in loadable apps and services.".

https://codereview.chromium.org/346613004/diff/660001/mojo/mojo.gyp#newcode428
mojo/mojo.gyp:428: # GN version: //mojo/environment:chromium
Presumably you need to update the GN build as well.

[qsr, 2014-07-01 08:09:35]

https://chromiumcodereview.appspot.com/346613004/diff/660001/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://chromiumcodereview.appspot.com/346613004/diff/660001/mojo/mojo.gyp#ne...
mojo/mojo.gyp:19: 'common_sources': [
On 2014/06/30 16:27:18, viettrungluu wrote:
> Probably you should have a comment explaining why we have variables for these.
> Something like: "We build two versions of these libraries, a version for use
in
> Chromium and the shell and an "embedded" version for use in loadable
> apps/services.".

Done.

https://chromiumcodereview.appspot.com/346613004/diff/660001/mojo/mojo.gyp#ne...
mojo/mojo.gyp:349: 'target_name': 'mojo_common_embedded_lib',
On 2014/06/30 16:27:17, viettrungluu wrote:
> It'd be nice if the non-embedded and embedded versions were in the same order
in
> the .gyp file (e.g., non-embedded, then embedded).
> 
> You should also have comments before each along the lines of "For use in
> Chromium and the shell."/"For use in loadable apps and services.".

Done.

https://chromiumcodereview.appspot.com/346613004/diff/660001/mojo/mojo.gyp#ne...
mojo/mojo.gyp:428: # GN version: //mojo/environment:chromium
On 2014/06/30 16:27:18, viettrungluu wrote:
> Presumably you need to update the GN build as well.

Done.

[qsr, 2014-07-02 10:36:19]

ben@ -> are you fine having the geometry and event library be static libraries?

[Ben Goodger (Google), 2014-07-07 19:20:15]

On 2014/07/02 10:36:19, qsr wrote:
> ben@ -> are you fine having the geometry and event library be static
libraries?



yes