Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/about_flags_switches_histogram_ids_checker/changed_file_7.h

Issue 344883002: Collect UMA statistics on which chrome://flags lead to chrome restart on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Presubmit hook added. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/about_flags_switches_histogram_ids_checker/changed_file_7.h
diff --git a/tools/strict_enum_value_checker/changed_file_7.h b/tools/about_flags_switches_histogram_ids_checker/changed_file_7.h
similarity index 60%
copy from tools/strict_enum_value_checker/changed_file_7.h
copy to tools/about_flags_switches_histogram_ids_checker/changed_file_7.h
index 61a2792e73cab27e805a1566aec59c2891e9d417..1e2ef67c07f534e5daba137dee350ab576855c2c 100644
--- a/tools/strict_enum_value_checker/changed_file_7.h
+++ b/tools/about_flags_switches_histogram_ids_checker/changed_file_7.h
@@ -12,22 +12,18 @@
// 3. New entries must be added just before mBoundary, never after
//
enum MockEnum {
- mEntry1,
- mEntry2,
- mData1,
- mData2,
- mEntry3,
- mInfo1,
- mData3,
- mInvalid1,
- mError1,
- mFunction1,
- mInvalid2,
- mInvalid3,
- mInfo2,
- mInvalid4,
- mData4,
- mBoundary // Do not add below here
+ UMA_HISTOGRAM_ID_Entry1,
+ UMA_HISTOGRAM_ID_Entry2,
+ UMA_HISTOGRAM_ID_Data1,
+ UMA_HISTOGRAM_ID_Data2,
+ UMA_HISTOGRAM_ID_Insertion,
+ UMA_HISTOGRAM_ID_Entry3,
+ UMA_HISTOGRAM_ID_Info1,
+ UMA_HISTOGRAM_ID_Data3,
+ UMA_HISTOGRAM_ID_Error1,
+ UMA_HISTOGRAM_ID_Function1,
+ UMA_HISTOGRAM_ID_Info2,
+ UMA_HISTOGRAM_ID_Data4,
};
#endif

Powered by Google App Engine
This is Rietveld 408576698