tools/about_flags_switches_histogram_ids_checker/changed_file_5.h - Issue 344883002: Collect UMA statistics on which chrome://flags lead to chrome restart on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/about_flags_switches_histogram_ids_checker/changed_file_5.h

Issue 344883002: Collect UMA statistics on which chrome://flags lead to chrome restart on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Presubmit hook added. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/about_flags_switches_histogram_ids_checker/about_flags_switches_histogram_ids_checker.py ('K') | « tools/about_flags_switches_histogram_ids_checker/changed_file_4.h ('k') | tools/about_flags_switches_histogram_ids_checker/changed_file_6.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/about_flags_switches_histogram_ids_checker/changed_file_5.h

diff --git a/tools/strict_enum_value_checker/changed_file_2.h b/tools/about_flags_switches_histogram_ids_checker/changed_file_5.h

similarity index 61%

copy from tools/strict_enum_value_checker/changed_file_2.h

copy to tools/about_flags_switches_histogram_ids_checker/changed_file_5.h

index 04a801bf5d831bdbd5053e6fe97e81fb06151b33..82092ce5968c04f6a9987726573624503be73cf7 100644

--- a/tools/strict_enum_value_checker/changed_file_2.h

+++ b/tools/about_flags_switches_histogram_ids_checker/changed_file_5.h

@@ -12,17 +12,18 @@

// 3. New entries must be added just before mBoundary, never after

enum MockEnum {

- mEntry1,

- mEntry2,

- mData1,

- mData2,

- mEntry3,

- mInfo1,

- mData3,

- mFunction1,

- mInfo2,

- mData4,

- mBoundary // Do not add below here

+ UMA_HISTOGRAM_ID_Entry1,

+ UMA_HISTOGRAM_ID_Entry2,

+ UMA_HISTOGRAM_ID_Data1,

+ UMA_HISTOGRAM_ID_Data2,

+ UMA_HISTOGRAM_ID_Entry3,

+ UMA_HISTOGRAM_ID_Info1,

+ UMA_HISTOGRAM_ID_Data3,

+ UMA_HISTOGRAM_ID_Error1,

+ UMA_HISTOGRAM_ID_Function1,

+ UMA_HISTOGRAM_ID_Info2,

+ UMA_HISTOGRAM_ID_Data4,

+ incorrectEntryName,

};

#endif