Issue 342473004: DevTools: make network conditions emulation scoped (browser)

Issue 342473004: DevTools: make network conditions emulation scoped (browser) (Closed)

Created:
6 years, 6 months ago by eustas

Modified:
6 years, 6 months ago

Reviewers:
vsevik, pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: make network conditions emulation scoped (browser) Currently network conditions are applied browser-wide. To restrict conditions to one tab requests are marked with specific headers. Those specific headers are removed before sending headers to network. BUG=245436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278109

Patch Set 1 #

Patch Set 2 : Pass-through command dispatching in delegate #

Patch Set 3 : fixed tests #

Patch Set 4 : Fixed nits #

Total comments: 2

Patch Set 5 : Addressed comments #

Total comments: 8

Patch Set 6 : Rename + fix nits + polish #

Total comments: 2

Patch Set 7 : #

Patch Set 8 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+411 lines, -396 lines)			Patch
M	chrome/browser/devtools/chrome_devtools_manager_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/devtools/chrome_devtools_manager_delegate.cc	View	1 2 3 4 5	3 chunks	+37 lines, -36 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_conditions.h	View	1 2 3 4	1 chunk	+14 lines, -9 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_conditions.cc	View	1 2 3 4	1 chunk	+22 lines, -18 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_controller.h	View	1 2 3 4 5	3 chunks	+14 lines, -42 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_controller.cc	View	1 2 3 4 5	2 chunks	+58 lines, -157 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_controller_unittest.cc	View	1 2 3 4 5	10 chunks	+53 lines, -40 lines	0 comments	Download
A	chrome/browser/devtools/devtools_network_interceptor.h	View	1 2 3 4 5	1 chunk	+70 lines, -0 lines	0 comments	Download
A +	chrome/browser/devtools/devtools_network_interceptor.cc	View	1 2 3 4 5 6 7	4 chunks	+66 lines, -86 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_transaction.h	View	1 2 3 4 5	7 chunks	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_network_transaction.cc	View	1 2 3 4 5	6 chunks	+46 lines, -7 lines	0 comments	Download
M	chrome/chrome_debugger.gypi	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

vsevik

https://chromiumcodereview.appspot.com/342473004/diff/60001/chrome/browser/devtools/devtools_network_controller.cc File chrome/browser/devtools/devtools_network_controller.cc (right): https://chromiumcodereview.appspot.com/342473004/diff/60001/chrome/browser/devtools/devtools_network_controller.cc#newcode93 chrome/browser/devtools/devtools_network_controller.cc:93: Transactions old_transactions(transactions_); Why is this handled in controller, not ...

6 years, 6 months ago (2014-06-18 09:18:04 UTC) #2

eustas

6 years, 6 months ago (2014-06-18 11:45:10 UTC) #3

vsevik

lgtm https://chromiumcodereview.appspot.com/342473004/diff/80001/chrome/browser/devtools/devtools_network_controller.cc File chrome/browser/devtools/devtools_network_controller.cc (right): https://chromiumcodereview.appspot.com/342473004/diff/80001/chrome/browser/devtools/devtools_network_controller.cc#newcode33 chrome/browser/devtools/devtools_network_controller.cc:33: if (!realms_.size()) This one should be above appcache ...

6 years, 6 months ago (2014-06-18 12:33:38 UTC) #4

eustas

https://codereview.chromium.org/342473004/diff/80001/chrome/browser/devtools/devtools_network_controller.cc File chrome/browser/devtools/devtools_network_controller.cc (right): https://codereview.chromium.org/342473004/diff/80001/chrome/browser/devtools/devtools_network_controller.cc#newcode33 chrome/browser/devtools/devtools_network_controller.cc:33: if (!realms_.size()) On 2014/06/18 12:33:37, vsevik wrote: > This ...

6 years, 6 months ago (2014-06-18 12:57:47 UTC) #5

vsevik

lgtm https://chromiumcodereview.appspot.com/342473004/diff/100001/chrome/browser/devtools/devtools_network_interceptor.cc File chrome/browser/devtools/devtools_network_interceptor.cc (right): https://chromiumcodereview.appspot.com/342473004/diff/100001/chrome/browser/devtools/devtools_network_interceptor.cc#newcode70 chrome/browser/devtools/devtools_network_interceptor.cc:70: } timer_.Stop(); return;

6 years, 6 months ago (2014-06-18 13:18:32 UTC) #6

eustas

https://codereview.chromium.org/342473004/diff/100001/chrome/browser/devtools/devtools_network_interceptor.cc File chrome/browser/devtools/devtools_network_interceptor.cc (right): https://codereview.chromium.org/342473004/diff/100001/chrome/browser/devtools/devtools_network_interceptor.cc#newcode70 chrome/browser/devtools/devtools_network_interceptor.cc:70: } On 2014/06/18 13:18:32, vsevik wrote: > timer_.Stop(); > ...

6 years, 6 months ago (2014-06-18 13:27:54 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/342473004/140001

6 years, 6 months ago (2014-06-18 13:30:58 UTC) #9

Message was sent while issue was closed.

Change committed as 278109

Expand Messages | Collapse Messages