Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 340113003: Add histograms to record the time since tab was last active. (Closed)

Created:
6 years, 6 months ago by lliabraa
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add histograms to record the time since tab was last active. Adds histograms to record the time since a tab was active when: - switching to the tab - switching to an evicted tab - protecting a tab on memory warning - evicting a tab on memory warning Also adds a histogram to show how often users switch to an evicted tab that was never active. BUG=385111 R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284061

Patch Set 1 #

Total comments: 2

Patch Set 2 : clarify comment; add Tab.EvictedTabWasActive #

Total comments: 2

Patch Set 3 : added example and marked new histograms with '[iOS]' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M histograms/histograms.xml View 3 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lliabraa
6 years, 6 months ago (2014-06-20 14:20:04 UTC) #1
Alexei Svitkine (slow)
For all of these, could you mention that these are specific to iOS? https://codereview.chromium.org/340113003/diff/1/histograms/histograms.xml File ...
6 years, 6 months ago (2014-06-20 14:48:56 UTC) #2
lliabraa
https://codereview.chromium.org/340113003/diff/1/histograms/histograms.xml File histograms/histograms.xml (right): https://codereview.chromium.org/340113003/diff/1/histograms/histograms.xml#newcode30403 histograms/histograms.xml:30403: + was active. On 2014/06/20 14:48:56, Alexei Svitkine wrote: ...
6 years, 6 months ago (2014-06-26 16:46:29 UTC) #3
Alexei Svitkine (slow)
lgtm % comment and other cl landing https://codereview.chromium.org/340113003/diff/20001/histograms/histograms.xml File histograms/histograms.xml (right): https://codereview.chromium.org/340113003/diff/20001/histograms/histograms.xml#newcode30277 histograms/histograms.xml:30277: + tab ...
6 years, 6 months ago (2014-06-26 17:00:43 UTC) #4
lliabraa
https://chromiumcodereview.appspot.com/340113003/diff/20001/histograms/histograms.xml File histograms/histograms.xml (right): https://chromiumcodereview.appspot.com/340113003/diff/20001/histograms/histograms.xml#newcode30277 histograms/histograms.xml:30277: + tab had ever been active. On 2014/06/26 17:00:43, ...
6 years, 5 months ago (2014-07-09 18:55:47 UTC) #5
lliabraa
6 years, 5 months ago (2014-07-18 12:04:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r284061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698