Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2788)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 339593005: Set the target type when creating the request for main resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 7ec49c36674ca3ab4768b7464b26e7f0e0950cad..750dc2b971b7c1d059a9e2394d45f5ab237d9015 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -2731,6 +2731,7 @@ TEST_F(WebFrameTest, ReloadWhileProvisional)
WebURLRequest request;
request.initialize();
request.setURL(toKURL(m_baseURL + "fixed_layout.html"));
+ request.initializeForMainResource(true);
webViewHelper.webView()->mainFrame()->loadRequest(request);
// start reload before first request is delivered.
FrameTestHelpers::reloadFrameIgnoringCache(webViewHelper.webView()->mainFrame());
@@ -5055,7 +5056,10 @@ TEST_F(WebFrameTest, NavigateToSame)
webViewHelper.initializeAndLoad(m_baseURL + "navigate_to_same.html", true, &client);
EXPECT_FALSE(client.frameLoadTypeSameSeen());
- WebCore::FrameLoadRequest frameRequest(0, WebCore::ResourceRequest(toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame())->document()->url()));
+ WebCore::ResourceRequest request = WebCore::ResourceRequest(
+ toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame())->document()->url());
+ request.initializeForMainResource(true);
+ WebCore::FrameLoadRequest frameRequest(0, request);
toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame())->loader().load(frameRequest);
FrameTestHelpers::pumpPendingRequestsDoNotUse(webViewHelper.webView()->mainFrame());
@@ -5275,6 +5279,7 @@ TEST_F(WebFrameTest, CurrentHistoryItem)
WebURLRequest request;
request.initialize();
request.setURL(toKURL(url));
+ request.initializeForMainResource(true);
frame->loadRequest(request);
// Before commit, there is no history item.

Powered by Google App Engine
This is Rietveld 408576698