Source/core/testing/MockPagePopupDriver.cpp - Issue 339593005: Set the target type when creating the request for main resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/MockPagePopupDriver.cpp

Issue 339593005: Set the target type when creating the request for main resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/FrameLoadRequest.h ('K') | « Source/core/svg/graphics/SVGImage.cpp ('k') | Source/platform/exported/WebURLRequest.cpp » ('j') | Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/testing/MockPagePopupDriver.cpp

diff --git a/Source/core/testing/MockPagePopupDriver.cpp b/Source/core/testing/MockPagePopupDriver.cpp

index 02d13e6bd290347cf3260c50dc9e06e0c666f7cf..9ee084db2b12517999c460250dc815807d3bb483 100644

--- a/Source/core/testing/MockPagePopupDriver.cpp

+++ b/Source/core/testing/MockPagePopupDriver.cpp

@@ -79,7 +79,9 @@ bool MockPagePopup::initialize()

LocalFrame* localFrame = toLocalFrame(m_iframe->contentFrame());

if (!localFrame)

return false;

- localFrame->loader().load(FrameLoadRequest(0, blankURL(), SubstituteData(data, "text/html", "UTF-8", KURL(), ForceSynchronousLoad)));

+ ResourceRequest request = ResourceRequest(blankURL());

+ request.initializeForMainResource(localFrame->isMainFrame());

+ localFrame->loader().load(FrameLoadRequest(0, request, SubstituteData(data, "text/html", "UTF-8", KURL(), ForceSynchronousLoad)));

return true;

}