Source/core/inspector/InspectorOverlay.cpp - Issue 339593005: Set the target type when creating the request for main resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 339593005: Set the target type when creating the request for main resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switched to constructors Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorOverlay.cpp

diff --git a/Source/core/inspector/InspectorOverlay.cpp b/Source/core/inspector/InspectorOverlay.cpp

index 2a324d8a28a6c6aae43dd5beab447877ce7449a5..25d429fe9a25d858001f6a07b94dcba2f279bacf 100644

--- a/Source/core/inspector/InspectorOverlay.cpp

+++ b/Source/core/inspector/InspectorOverlay.cpp

@@ -713,7 +713,8 @@ Page* InspectorOverlay::overlayPage()

frame->view()->setTransparent(true);

RefPtr<SharedBuffer> data = SharedBuffer::create(reinterpret_cast<const char*>(InspectorOverlayPage_html), sizeof(InspectorOverlayPage_html));

- loader.load(FrameLoadRequest(0, blankURL(), SubstituteData(data, "text/html", "UTF-8", KURL(), ForceSynchronousLoad)));

+ ResourceRequest request = ResourceRequest(blankURL(), frame->isMainFrame());

+ loader.load(FrameLoadRequest(0, request, SubstituteData(data, "text/html", "UTF-8", KURL(), ForceSynchronousLoad)));

v8::Isolate* isolate = toIsolate(frame.get());

ScriptState* scriptState = ScriptState::forMainWorld(frame.get());

ASSERT(!scriptState->contextIsEmpty());

« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »