Source/web/tests/FrameTestHelpers.cpp - Issue 339593005: Set the target type when creating the request for main resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/FrameTestHelpers.cpp

Issue 339593005: Set the target type when creating the request for main resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Made the setter method private Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/FrameTestHelpers.cpp

diff --git a/Source/web/tests/FrameTestHelpers.cpp b/Source/web/tests/FrameTestHelpers.cpp

index 0b4153c56a7ca1305404c15b3ca45d7b2d9a229f..741fabb5fdc12b69ad530b791edfdb011368c6ec 100644

--- a/Source/web/tests/FrameTestHelpers.cpp

+++ b/Source/web/tests/FrameTestHelpers.cpp

@@ -206,9 +206,7 @@ WebViewClient* defaultWebViewClient()

void loadFrame(WebFrame* frame, const std::string& url)

{

- WebURLRequest urlRequest;

- urlRequest.initialize();

- urlRequest.setURL(URLTestHelpers::toKURL(url));

+ WebURLRequest urlRequest(URLTestHelpers::toKURL(url), true, !frame->parent());

Platform::current()->currentThread()->postTask(new LoadTask(frame, urlRequest));

pumpPendingRequests(frame);

« Source/platform/network/ResourceRequest.h ('K') | « Source/web/WebSharedWorkerImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »