Source/core/page/CreateWindow.cpp - Issue 339593005: Set the target type when creating the request for main resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 339593005: Set the target type when creating the request for main resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Made the setter method private Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/CreateWindow.cpp

diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp

index 0c7b8f7d1cf24c231f6cb03d8c16b074c51a8e9e..15aaec48a967b4ec2b4e0661670d7ee81b3e3398 100644

--- a/Source/core/page/CreateWindow.cpp

+++ b/Source/core/page/CreateWindow.cpp

@@ -153,7 +153,9 @@ LocalFrame* createWindow(const String& urlString, const AtomicString& frameName,

function(newFrame->domWindow(), functionContext);

if (created) {

- FrameLoadRequest request(callingWindow.document(), ResourceRequest(completedURL, referrer));

+ ResourceRequest resourceRequest = ResourceRequest::createMainResourceRequest(

+ completedURL, newFrame->isMainFrame(), referrer);

+ FrameLoadRequest request(callingWindow.document(), resourceRequest);

newFrame->loader().load(request);

} else if (!urlString.isEmpty()) {

newFrame->navigationScheduler().scheduleLocationChange(callingWindow.document(), completedURL.string(), referrer, false);

« no previous file with comments | « Source/core/loader/NavigationScheduler.cpp ('k') | Source/core/page/DragController.cpp » ('j') | Source/platform/network/ResourceRequest.h » ('J')