Set the target type when creating the request for main resource

Source/platform/network/ResourceRequest.h

 /*
  * Copyright (C) 2003, 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 75 matching lines @@
     ResourceRequest(const String& urlString)
     {
         initialize(KURL(ParsedURLString, urlString), UseProtocolCachePolicy);
     }
 
     ResourceRequest(const KURL& url)
     {
         initialize(url, UseProtocolCachePolicy);
     }
 
     ResourceRequest(const KURL& url, const Referrer& referrer, ResourceRequestCachePolicy cachePolicy = UseProtocolCachePolicy)

[Nate Chapin, 2014/06/24 18:28:54]

Is this constructor actually used for subresource loads? I would have guessed it
was main resource only.

[clamy, 2014/06/25 15:47:11]

You're right it is only used by main resources. I added a parameter to it.

     {
         initialize(url, cachePolicy);
         setHTTPReferrer(referrer);
     }
 
+    // Factory methods that should be used when creating a ResourceRequest for a
+    // main resource.
+    static ResourceRequest createMainResourceRequest(const KURL&, bool isMainFrame);

[Nate Chapin, 2014/06/24 18:28:54]

Why is it better to have these static factory methods instead than constructors
(like the other ways to create a ResourceRequest)?

[clamy, 2014/06/25 15:47:11]

I thought it was more explicit that they give you a ResourceRequest that should
only be used for main resources. But it doesn't fit very well with the rest of
the code which uses constructors. So I made a new patch set with constructors,
so that we only have one way to create a ResourceRequest.

+    static ResourceRequest createMainResourceRequest(
+        const KURL&, bool isMainFrame, const Referrer&, ResourceRequestCachePolicy = UseProtocolCachePolicy);
+
     static PassOwnPtr<ResourceRequest> adopt(PassOwnPtr<CrossThreadResourceRequestData>);
 
     // Gets a copy of the data suitable for passing to another thread.
     PassOwnPtr<CrossThreadResourceRequestData> copyData() const;
 
     bool isNull() const;
     bool isEmpty() const;
 
     const KURL& url() const;
     void setURL(const KURL& url);
@@ skipping 98 matching lines @@
     bool hasCacheValidatorFields() const;
 
     static double defaultTimeoutInterval(); // May return 0 when using platform default.
     static void setDefaultTimeoutInterval(double);
 
     static bool compare(const ResourceRequest&, const ResourceRequest&);
 
 private:
     void initialize(const KURL& url, ResourceRequestCachePolicy cachePolicy);
 
+    void setTargetTypeForMainResource(bool isMainFrame);
+
     const CacheControlHeader& cacheControlHeader() const;
 
     KURL m_url;
     ResourceRequestCachePolicy m_cachePolicy;
     double m_timeoutInterval; // 0 is a magic value for platform default on platforms that have one.
     KURL m_firstPartyForCookies;
     AtomicString m_httpMethod;
     HTTPHeaderMap m_httpHeaderFields;
     RefPtr<FormData> m_httpBody;
     bool m_allowStoredCredentials : 1;
@@ skipping 44 matching lines @@
     int m_appCacheHostID;
     ResourceRequest::TargetType m_targetType;
     ReferrerPolicy m_referrerPolicy;
 };
 
 unsigned initializeMaximumHTTPConnectionCountPerHost();
 
 } // namespace WebCore
 
 #endif // ResourceRequest_h