Set metainfo ID for enhanced bookmarks extension

chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <algorithm>
+
 #include "chrome/browser/extensions/api/bookmarks/bookmarks_api.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/i18n/time_formatting.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_service.h"
+#include "base/rand_util.h"
 #include "base/sha1.h"
 #include "base/stl_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/bookmarks/bookmark_html_writer.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/bookmarks/chrome_bookmark_client.h"
@@ skipping 11 matching lines @@
 #include "chrome/common/importer/importer_data_types.h"
 #include "chrome/common/pref_names.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/browser/bookmark_utils.h"
 #include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_function_dispatcher.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/browser/quota_service.h"
+#include "extensions/common/permissions/permissions_data.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_WIN)
 #include "ui/aura/remote_window_tree_host_win.h"
 #endif
 
 namespace extensions {
 
 namespace keys = bookmark_api_constants;
@@ skipping 31 matching lines @@
                                  base::TimeFormatShortDateNumeric(time));
 #endif
 
   file_util::ReplaceIllegalCharactersInPath(&filename, '_');
 
   base::FilePath default_path;
   PathService::Get(chrome::DIR_USER_DOCUMENTS, &default_path);
   return default_path.Append(filename);
 }
 
+bool IsEnhancedBookmarksExtensionActive(Profile* profile) {
+  static const char *enhanced_extension_hashes[] = {

[Yoyo Zhou, 2014/06/13 23:54:00]

Comment what extensions these represent.

[Mike Wittman, 2014/06/14 00:49:55]

Done.

+    "D5736E4B5CF695CB93A2FB57E4FDC6E5AFAB6FE2",
+    "D57DE394F36DC1C3220E7604C575D29C51A6C495",
+    "3F65507A3B39259B38C8173C6FFA3D12DF64CCE9"
+  };
+  const ExtensionSet& extensions =
+      ExtensionRegistry::Get(profile)->enabled_extensions();
+  for (ExtensionSet::const_iterator it = extensions.begin();
+       it != extensions.end(); ++it) {
+    const Extension* extension = *it;
+    if (extension->permissions_data()->HasAPIPermission(
+            APIPermission::kBookmarkManagerPrivate)) {
+      std::string hash = base::SHA1HashString(extension->id());
+      hash = base::HexEncode(hash.c_str(), hash.length());
+      for (size_t i = 0; i < arraysize(enhanced_extension_hashes); i++)
+        if (hash == enhanced_extension_hashes[i])
+          return true;
+    }
+  }
+  return false;
+}
+
+std::string ToBase36(int64 value) {
+  DCHECK(value >= 0);
+  std::string str;
+  while (value > 0) {
+    int digit = value % 36;
+    value /= 36;
+    str += (digit < 10 ? '0' + digit : 'a' + digit - 10);
+  }
+  std::reverse(str.begin(), str.end());
+  return str;
+}
+
+// Generate a metadata ID based on a the current time and a random number for
+// enhanced bookmarks, to be assigned pre-sync.
+std::string GenerateEnhancedBookmarksID(bool is_folder) {
+  static const char bookmark_prefix[] = "cc_";
+  static const char folder_prefix[] = "cf_";
+  // Use [0..range_mid) for bookmarks, [range_mid..2*range_mid) for folders.

[Yoyo Zhou, 2014/06/13 23:54:00]

Why is this necessary? They have different prefixes already.

[Mike Wittman, 2014/06/14 00:49:55]

To match the existing extension and server-side behavior. Not sure why it was
done this way in the first place.

+  int range_mid = 36*36*36*36 / 2;
+  int rand = base::RandInt(0, range_mid - 1);
+  int64 unix_epoch_time_in_ms =
+      (base::Time::Now() - base::Time::UnixEpoch()).InMilliseconds();
+  return std::string(is_folder ? folder_prefix : bookmark_prefix) +
+      ToBase36(is_folder ? range_mid + rand : rand) +
+      ToBase36(unix_epoch_time_in_ms);
+}
+
 }  // namespace
 
 bool BookmarksFunction::RunAsync() {
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
   if (!model->loaded()) {
     // Bookmarks are not ready yet.  We'll wait.
     model->AddObserver(this);
     AddRef();  // Balanced in Loaded().
     return true;
   }
@@ skipping 172 matching lines @@
   move_info.parent_id = base::Int64ToString(new_parent->id());
   move_info.index = new_index;
   move_info.old_parent_id = base::Int64ToString(old_parent->id());
   move_info.old_index = old_index;
 
   DispatchEvent(
       bookmarks::OnMoved::kEventName,
       bookmarks::OnMoved::Create(base::Int64ToString(node->id()), move_info));
 }
 
+void BookmarkEventRouter::BookmarkNodeAdding(BookmarkModel* model,
+                                             BookmarkNode* node) {
+  // TODO(wittman): Remove this once extension hooks are in place to allow the
+  // enhanced bookmarks extension to manage all bookmark creation code
+  // paths. See http://crbug.com/383557.
+  if (IsEnhancedBookmarksExtensionActive(Profile::FromBrowserContext(
+          browser_context_))) {
+    static const char key[] = "stars.id";
+    node->SetMetaInfo(key, GenerateEnhancedBookmarksID(node->is_folder()));
+  }
+}
+
 void BookmarkEventRouter::BookmarkNodeAdded(BookmarkModel* model,
                                             const BookmarkNode* parent,
                                             int index) {
   const BookmarkNode* node = parent->GetChild(index);
   scoped_ptr<BookmarkTreeNode> tree_node(
       bookmark_api_helpers::GetBookmarkTreeNode(client_, node, false, false));
   DispatchEvent(bookmarks::OnCreated::kEventName,
                 bookmarks::OnCreated::Create(base::Int64ToString(node->id()),
                                              *tree_node));
 }
@@ skipping 739 matching lines @@
 #if !defined(OS_ANDROID)
   // Android does not have support for the standard exporter.
   // TODO(jgreenwald): remove ifdef once extensions are no longer built on
   // Android.
   bookmark_html_writer::WriteBookmarks(GetProfile(), path, NULL);
 #endif
   Release();  // Balanced in BookmarksIOFunction::SelectFile()
 }
 
 }  // namespace extensions