extensions/browser/extension_function_histogram_value.h - Issue 336283002: Remove GuestWebContentsCreated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function_histogram_value.h

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation

Patch Set: Simplified comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_function_histogram_value.h

diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h

index 0de3dfc55290459bb35eedc1cdf64f4f6737bc9c..f4bff1d16e117c889c3bad6c31948db692ba8f2f 100644

--- a/extensions/browser/extension_function_histogram_value.h

+++ b/extensions/browser/extension_function_histogram_value.h

@@ -844,13 +844,13 @@ enum HistogramValue {

STREAMSPRIVATE_ABORT,

MANAGEMENT_SETLAUNCHTYPE,

MANAGEMENT_GENERATEAPPFORLINK,

- GUESTVIEWINTERNAL_ALLOCATEINSTANCEID,

WEBVIEW_NAVIGATE,

INPUTMETHODPRIVATE_GETCURRENTINPUTMETHOD,

INPUTMETHODPRIVATE_SETCURRENTINPUTMETHOD,

INPUTMETHODPRIVATE_GETINPUTMETHODS,

IDENTITY_GETPROFILEUSERINFO,

FILESYSTEMPROVIDERINTERNAL_OPERATIONREQUESTEDERROR,

+ GUESTVIEWINTERNAL_CREATEGUEST,

lazyboy 2014/06/19 16:17:31 I'm not entirely sure it is a good idea to remove

Fady Samuel 2014/06/20 15:16:35 Will ask.

// Last entry: Add new entries above and ensure to update

// tools/metrics/histograms/histograms/histograms.xml.

ENUM_BOUNDARY

« no previous file with comments | « content/public/browser/web_contents.cc ('k') | no next file » | no next file with comments »